From: Chris Wright <chrisw@osdl.org>
To: Borislav Deianov <borislav@users.sourceforge.net>
Cc: len.brown@intel.com, Chris Wright <chrisw@osdl.org>,
Karsten Wiese <annabellesgarden@yahoo.de>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
acpi-devel@lists.sourceforge.net
Subject: Re: [PATCH] ibm-acpi-0.8 (was Re: 2.6.10-rc1-mm3)
Date: Mon, 8 Nov 2004 18:12:24 -0800 [thread overview]
Message-ID: <20041108181224.F2357@build.pdx.osdl.net> (raw)
In-Reply-To: <20041109013013.GA21832@aero.ensim.com>; from borislav@users.sourceforge.net on Mon, Nov 08, 2004 at 05:30:13PM -0800
* Borislav Deianov (borislav@users.sourceforge.net) wrote:
> On Mon, Nov 08, 2004 at 03:30:22PM -0800, Chris Wright wrote:
> >
> > The init error cleanup paths are broken in that driver. It creates the
> > /proc/acpi/ibm dir and forgets to clean it up. Partially that's due to
> > returning directly from the macro IBM_HANDLE_INIT_REQ. This should help.
>
> Yikes. Guilty as charged.
>
> I reworked Chris's patch a bit and tried both the error and non-error
> case here. Len, if it looks good, please apply.
Ah, even better. Thanks Boris. BTW, you could probably mark ibm_init()
and ibm_handle_init() as __init.
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
next prev parent reply other threads:[~2004-11-09 2:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200411081334.18751.annabellesgarden@yahoo.de>
[not found] ` <200411082240.02787.annabellesgarden@yahoo.de>
[not found] ` <20041108153022.N14339@build.pdx.osdl.net>
2004-11-09 1:30 ` [PATCH] ibm-acpi-0.8 (was Re: 2.6.10-rc1-mm3) Borislav Deianov
2004-11-09 2:12 ` Chris Wright [this message]
2004-11-09 2:31 ` Borislav Deianov
[not found] ` <20041109023119.GB21832-AKoe11r2kkOzaBltdDZI6w@public.gmane.org>
2004-11-29 0:34 ` Rusty Russell
[not found] ` <20041109013013.GA21832-AKoe11r2kkOzaBltdDZI6w@public.gmane.org>
2004-11-09 6:31 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041108181224.F2357@build.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=acpi-devel@lists.sourceforge.net \
--cc=akpm@osdl.org \
--cc=annabellesgarden@yahoo.de \
--cc=borislav@users.sourceforge.net \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox