From: Greg KH <greg@kroah.com>
To: Li Shaohua <shaohua.li@intel.com>
Cc: ACPI-DEV <acpi-devel@lists.sourceforge.net>,
lkml <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>,
Patrick Mochel <mochel@digitalimplant.org>
Subject: Re: [PATCH/RFC 1/4]device core changes
Date: Mon, 8 Nov 2004 14:58:10 -0800 [thread overview]
Message-ID: <20041108225810.GB16197@kroah.com> (raw)
In-Reply-To: <1099887071.1750.243.camel@sli10-desk.sh.intel.com>
On Mon, Nov 08, 2004 at 12:11:11PM +0800, Li Shaohua wrote:
> Hi,
> This is the device core change required. Add .platform_bind method for
> bus_type, so platform can do addition things when add a new device. A
> case is ACPI, we want to utilize some ACPI methods for physical devices.
> 1. Why doesn't use 'platform_notify'?
> Current device core has a 'platform_notify' mechanism, but it's not
> sufficient for this. Only sepcific bus type know how to parse dev.bus_id
> and know how to encode specific device's address into ACPI _ADR syntax.
I don't see why platform_notify is not sufficient. This is the exact
reason it was added to the code.
> 2. Why adds new 'handle' in 'struct device'?
> 'Platform_data' is the best candidate, but a search shows some drivers
> have used it. We can remove 'handle' after the drivers changes their
> behavior.
No, fix the drivers. Don't add something that you are going to remove
later.
thanks,
greg k-h
next prev parent reply other threads:[~2004-11-08 22:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-08 4:11 [PATCH/RFC 1/4]device core changes Li Shaohua
2004-11-08 22:58 ` Greg KH [this message]
2004-11-09 0:50 ` Li Shaohua
2004-11-09 3:35 ` Li Shaohua
[not found] ` <1099971341.15294.48.camel-U5EdaLXB8smDugQYiPIPGdh3ngVCH38I@public.gmane.org>
2004-11-09 4:58 ` Greg KH
[not found] ` <20041109045843.GA4849-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2004-11-09 9:03 ` Li Shaohua
[not found] ` <1099990981.15294.57.camel-U5EdaLXB8smDugQYiPIPGdh3ngVCH38I@public.gmane.org>
2004-11-10 1:24 ` Greg KH
[not found] ` <20041110012443.GA9496-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2004-11-10 1:45 ` Li Shaohua
2004-11-10 4:28 ` Russell King
[not found] ` <20041110042822.A13318-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2004-11-11 7:03 ` Li Shaohua
[not found] ` <1100156613.8769.26.camel-U5EdaLXB8smDugQYiPIPGdh3ngVCH38I@public.gmane.org>
2004-11-11 8:44 ` Russell King
[not found] ` <20041111084411.A2400-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2004-11-11 8:46 ` Li Shaohua
2004-11-12 0:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041108225810.GB16197@kroah.com \
--to=greg@kroah.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox