Re: [PATCH] ibm-acpi-0.8 (was Re: 2.6.10-rc1-mm3)

Chris Wright
2004-11-09T02:12:24Z

* Borislav Deianov (borislav@users.sourceforge.net) wrote:
> On Mon, Nov 08, 2004 at 03:30:22PM -0800, Chris Wright wrote:
> >
> > The init error cleanup paths are broken in that driver. It creates the
> > /proc/acpi/ibm dir and forgets to clean it up. Partially that's due to
> > returning directly from the macro IBM_HANDLE_INIT_REQ. This should help.
>
> Yikes. Guilty as charged.
>
> I reworked Chris's patch a bit and tried both the error and non-error
> case here. Len, if it looks good, please apply.

Ah, even better. Thanks Boris. BTW, you could probably mark ibm_init()
and ibm_handle_init() as __init.

-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net