From: Keshavamurthy Anil S <anil.s.keshavamurthy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: ACPI Developer
<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: [PATCH] processor.ko: use kobject_hotplug() to notify user agent
Date: Wed, 10 Nov 2004 18:22:13 -0800 [thread overview]
Message-ID: <20041110182213.B15383@unix-os.sc.intel.com> (raw)
Hi Len,
This is again due to "hotplug_path" getting un-exported from mm3, this below code which was
depending on hotlpug_path was breaking from compiling. Now using kobject_hotplut() to notify user agenet.
This patch fixes the undefined "hotplug_path" warning.
Please apply this fix.
---
linux-2.6.10-rc1-mm4-askeshav/drivers/acpi/processor.c | 58 +----------------
1 files changed, 4 insertions(+), 54 deletions(-)
diff -puN drivers/acpi/processor.c~processor_u1_hotplug_path_fix drivers/acpi/processor.c
--- linux-2.6.10-rc1-mm4/drivers/acpi/processor.c~processor_u1_hotplug_path_fix 2004-11-10 13:33:38.143298918 -0800
+++ linux-2.6.10-rc1-mm4-askeshav/drivers/acpi/processor.c 2004-11-10 13:33:38.220447354 -0800
@@ -2628,56 +2628,6 @@ static struct dmi_system_id __initdata p
static int is_processor_present(acpi_handle handle);
static int
-processor_run_sbin_hotplug(struct acpi_device *device,
- int cpu, char *action)
-{
- char *argv[3], *envp[7], action_str[32], cpu_str[15];
- int i, ret;
- int len;
- char pathname[ACPI_PATHNAME_MAX] = {0};
- acpi_status status;
- char *processor_str;
- struct acpi_buffer buffer = {ACPI_PATHNAME_MAX, pathname};
-
- ACPI_FUNCTION_TRACE("processor_run_sbin_hotplug");
-
-
- status = acpi_get_name(device->handle, ACPI_FULL_PATHNAME, &buffer);
- if (ACPI_FAILURE(status)) {
- return(-ENODEV);
- }
-
- len = strlen("PROCESSOR=") + strlen(pathname) + 1;
- processor_str = kmalloc(len, GFP_KERNEL);
- if (!processor_str)
- return(-ENOMEM);
-
- sprintf(processor_str, "PROCESSOR=%s",pathname);
- sprintf(action_str, "ACTION=%s", action);
- sprintf(cpu_str, "CPU=%d", cpu);
-
- i = 0;
- argv[i++] = hotplug_path;
- argv[i++] = "cpu";
- argv[i] = NULL;
-
- i = 0;
- envp[i++] = "HOME=/";
- envp[i++] = "PATH=/sbin;/bin;/usr/sbin;/usr/bin";
- envp[i++] = action_str;
- envp[i++] = processor_str;
- envp[i++] = cpu_str;
- envp[i++] = "PLATFORM=ACPI";
- envp[i] = NULL;
-
- ret = call_usermodehelper(argv[0], argv, envp, 0);
-
- kfree(processor_str);
- return_VALUE(ret);
-}
-
-
-static int
is_processor_present(
acpi_handle handle)
{
@@ -2726,7 +2676,7 @@ int acpi_processor_device_add(
return_VALUE(-ENODEV);
if ((pr->id >=0) && (pr->id < NR_CPUS)) {
- processor_run_sbin_hotplug(*device, pr->id, "add");
+ kobject_hotplug(&(*device)->kobj, KOBJ_ONLINE);
}
return_VALUE(0);
}
@@ -2770,13 +2720,13 @@ acpi_processor_hotplug_notify (
}
if (pr->id >= 0 && (pr->id < NR_CPUS)) {
- processor_run_sbin_hotplug(device, pr->id, "remove");
+ kobject_hotplug(&device->kobj, KOBJ_OFFLINE);
break;
}
result = acpi_processor_start(device);
if ((!result) && ((pr->id >=0) && (pr->id < NR_CPUS))) {
- processor_run_sbin_hotplug(device, pr->id, "add");
+ kobject_hotplug(&device->kobj, KOBJ_ONLINE);
} else {
ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
"Device [%s] failed to start\n",
@@ -2797,7 +2747,7 @@ acpi_processor_hotplug_notify (
}
if ((pr->id < NR_CPUS) && (cpu_present(pr->id)))
- processor_run_sbin_hotplug(device, pr->id, "remove");
+ kobject_hotplug(&device->kobj, KOBJ_OFFLINE);
break;
default:
ACPI_DEBUG_PRINT((ACPI_DB_INFO,
_
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
next reply other threads:[~2004-11-11 2:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-11 2:22 Keshavamurthy Anil S [this message]
[not found] ` <20041110182213.B15383-39QZ/XbsZ5/mO6KZMuUCQVaTQe2KTcn/@public.gmane.org>
2004-11-11 8:56 ` [PATCH] processor.ko: use kobject_hotplug() to notify user agent Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041110182213.B15383@unix-os.sc.intel.com \
--to=anil.s.keshavamurthy-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox