public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Wang, Zhenyu" <zhenyu.z.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: dev_zero <dev_xor-eZNTXLQAfP4@public.gmane.org>
Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: kacpid problems
Date: Thu, 11 Nov 2004 09:22:28 +0800	[thread overview]
Message-ID: <20041111012228.GA18032@zhen-devel.sh.intel.com> (raw)
In-Reply-To: <20041110170945.38831.qmail-uk6eOWkoXtXGRxTy+Q50vsz6deESKz/lQQ4Iyu8u01E@public.gmane.org>

copy these from acpi_thermal_remove, does this workaround your issue?

--- acpi-2.6/drivers/acpi/thermal.c~remove_queue_work	2004-11-10 23:38:51.000000000 +0800
+++ acpi-2.6/drivers/acpi/thermal.c	2004-11-11 09:19:57.365634568 +0800
@@ -472,6 +472,13 @@ acpi_thermal_critical (
 	printk(KERN_EMERG "Critical temperature reached (%ld C), shutting down.\n", KELVIN_TO_CELSIUS(tz->temperature));
 	acpi_bus_generate_event(device, ACPI_THERMAL_NOTIFY_CRITICAL, tz->trips.critical.flags.enabled);
 
+	tz->zombie = 1;
+	/* wait for running timer (on other CPUs) finish */
+	del_timer_sync(&(tz->timer));
+	/* synchronize deferred task */
+	acpi_os_wait_events_complete(NULL);
+	/* deferred task may reinsert timer */
+	del_timer_sync(&(tz->timer));
 	acpi_thermal_call_usermode(ACPI_THERMAL_PATH_POWEROFF);
 
 	return_VALUE(0);


On 2004.11.10 18:09:45 +0000, dev_zero wrote:
> This patch actually made some difference. I could play
> much longer now. First it started lagging, then it
> stopped, then it started lagging again, then it
> stopped. It went like this for a while, but after I
> had played som more, it started lagging again but now
> it didn't stop.
> 
>  --- "Wang, Zhenyu" <zhenyu.z.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote: 
> > oops,
> > 
> > ---
> > acpi-2.6/drivers/acpi/thermal.c~remove_queue_work
> > 2004-11-10 23:38:51.693022464 +0800
> > +++ acpi-2.6/drivers/acpi/thermal.c	2004-11-10
> > 23:52:40.820975856 +0800
> > @@ -472,6 +472,8 @@ acpi_thermal_critical (
> >  	printk(KERN_EMERG "Critical temperature reached
> > (%ld C), shutting down.\n",
> > KELVIN_TO_CELSIUS(tz->temperature));
> >  	acpi_bus_generate_event(device,
> > ACPI_THERMAL_NOTIFY_CRITICAL,
> > tz->trips.critical.flags.enabled);
> >  
> > +	tz->zombie = 1;
> > +	acpi_os_wait_events_complete(NULL);
> >  
> >
> acpi_thermal_call_usermode(ACPI_THERMAL_PATH_POWEROFF);
> >  
> >  	return_VALUE(0);
> > 
> > If this has no help, maybe others eat up kacpid..
> > 
> > On 2004.11.10 23:44:33 +0000, Wang, Zhenyu wrote:
> > > Pls try this patch,
> > > 
> > > ---
> > acpi-2.6/drivers/acpi/thermal.c~remove_queue_work  
> > 2004-11-10 23:38:51.693022464 +0800
> > > +++ acpi-2.6/drivers/acpi/thermal.c     2004-11-10
> > 23:39:50.195128792 +0800
> > > @@ -472,6 +472,7 @@ acpi_thermal_critical (
> > >         printk(KERN_EMERG "Critical temperature
> > reached (%ld C), shutting down.\n",
> > KELVIN_TO_CELSIUS(tz->temperature));
> > >         acpi_bus_generate_event(device,
> > ACPI_THERMAL_NOTIFY_CRITICAL,
> > tz->trips.critical.flags.enabled);
> > > 
> > > +       tz->zombie = 1;
> > >        
> >
> acpi_thermal_call_usermode(ACPI_THERMAL_PATH_POWEROFF);
> > > 
> > >         return_VALUE(0);
> > > 
> > > Is this work?
> > > 
> > > -zhen
> > > 
> > > On 2004.11.10 14:33:35 +0000, dev_zero wrote:
> > > > kacpid still runns with 99%cpu usage when the
> > cpu gets
> > > > too hot. I tried the game quake 2. You can play
> > around
> > > > 10 -15 minutes before the kacpid starts running
> > on 99%
> > > > cpu usage. I also used quake 2 too test the
> > kernel
> > > > before I applied your patch.
> > > > 
> > > >  --- "Yu, Luming" <luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote: 
> > > > > It means there was NO event generated at that
> > time.
> > > > > Do you think the symptom is gone with my debug
> > > > > patch?
> > > > > If so, I think your box need a more sane
> > schedule
> > > > > for acpi_thermal_check 
> > > > > And, I can come up with a patch.
> > > > > 
> > > > > Thanks
> > > > > Luming 
> > > > > 
> > > > > >-----Original Message-----
> > > > > >From: dev_zero [mailto:dev_xor-eZNTXLQAfP4@public.gmane.org] 
> > > > > >Sent: 2004年11月10日 1:06
> > > > > >To: Yu, Luming
> > > > > >Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > > > > >Subject: RE: [ACPI] kacpid problems
> > > > > >
> > > > > >When I try to output the event file I do
> > this:
> > > > > >[root@balder: /proc/acpi]# cat event >
> > > > > /home/event.log
> > > > > >
> > > > > >But then It just stands there without doing
> > > > > anything.
> > > > > >So i tried to check what was wrong (ps ax)
> > command:
> > > > > >2922 pts/0    S+     0:00 cat event
> > > > > >
> > > > > >I don't know if it is supposed to be
> > suspended?
> > > > > >> I want to know what kind of events could be
> > > > > >> generated heavily, which could have
> > corresponding
> > > > > >> pending execution of AML method issued to
> > work
> > > > > queue
> > > > > >> handled by kacpid.  So just cat
> > /proc/acpi/event
> > > > > >
> > > > > >> event.log
> > > > > >> to me when you were observing abnormal  cpu
> > > > > >> consumption by kacpid.  
> > > > > >> 
> > > > > >> Thanks
> > > > > >> Luming 
> > > > > >> 
> > > > > >> >-----Original Message-----
> > > > > >> >From: dev_zero [mailto:dev_xor-eZNTXLQAfP4@public.gmane.org] 
> > > > > >> >Sent: 2004Äê11ÔÂ10ÈÕ 0:00
> > > > > >> >To: Yu, Luming
> > > > > >> >Subject: RE: [ACPI] kacpid problems
> > > > > >> >
> > > > > >> >Of course.. But which log files do you
> > want to
> > > > > take
> > > > > >> a
> > > > > >> >look at?
> > > > > >> >> >How am i supppose to get an output from
> > > > > >> >> >/proc/acpi/event ??? I can't access the
> > file,
> > > > > >> >> because
> > > > > >> >> >it's in use.
> > > > > >> >> 
> > > > > >> >> Just kill acpid or the similar.
> > > > > >> >> 
> > > > > >> >> 
> > > > > >> >>
> > > > > >>
> > > > >
> > > >
> >
> >>-------------------------------------------------------
> > > > > >> >> This SF.Net email is sponsored by:
> > > > > >> >> Sybase ASE Linux Express Edition -
> > download
> > > > > now
> > > > > >> for
> > > > > >> >> FREE
> > > > > >> >> LinuxWorld Reader's Choice Award Winner
> > for
> > > > > best
> > > > > >> >> database on Linux.
> > > > > >> >>
> > > > > >>
> > > > >
> > http://ads.osdn.com/?ad_idU88&alloc_id\x12065&op=click
> > > > > >> >>
> > > > >
> > _______________________________________________
> > > > > >> >> Acpi-devel mailing list
> > > > > >> >> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > > > > >> >>
> > > > > >>
> > > > >
> > > >
> >
> >>https://lists.sourceforge.net/lists/listinfo/acpi-devel
> > > > > >> >>  
> > > > > >> >
> > > > > >>  
> > > > > >
> > > > > 
> > > > 
> > > > 
> > > >
> >
> -------------------------------------------------------
> > > > This SF.Net email is sponsored by:
> > > > Sybase ASE Linux Express Edition - download now
> > for FREE
> > > > LinuxWorld Reader's Choice Award Winner for best
> > database on Linux.
> > > >
> >
> http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
> > > > _______________________________________________
> > > > Acpi-devel mailing list
> > > > Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > > >
> >
> https://lists.sourceforge.net/lists/listinfo/acpi-devel
> > > 
> > > 
> > >
> >
> -------------------------------------------------------
> > > This SF.Net email is sponsored by:
> > > Sybase ASE Linux Express Edition - download now
> > for FREE
> > > LinuxWorld Reader's Choice Award Winner for best
> > database on Linux.
> > >
> > http://ads.osdn.com/?ad_idU88&alloc_id\x12065&op=click
> > > _______________________________________________
> > > Acpi-devel mailing list
> > > Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > >
> >
> https://lists.sourceforge.net/lists/listinfo/acpi-devel
> >  
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by:
> Sybase ASE Linux Express Edition - download now for FREE
> LinuxWorld Reader's Choice Award Winner for best database on Linux.
> http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel


-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_idU88&alloc_id\x12065&op=click

  parent reply	other threads:[~2004-11-11  1:22 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-10  9:37 kacpid problems Yu, Luming
2004-11-10 13:33 ` dev_zero
     [not found]   ` <20041110133335.84968.qmail-dJK20/AG75nGRxTy+Q50vsz6deESKz/lQQ4Iyu8u01E@public.gmane.org>
2004-11-10 15:44     ` Wang, Zhenyu
     [not found]       ` <20041110154433.GA14613-/VnEId6AORcBH7GVJk7YB9h3ngVCH38I@public.gmane.org>
2004-11-10 15:54         ` Wang, Zhenyu
     [not found]           ` <20041110155455.GA14675-/VnEId6AORcBH7GVJk7YB9h3ngVCH38I@public.gmane.org>
2004-11-10 17:09             ` dev_zero
     [not found]               ` <20041110170945.38831.qmail-uk6eOWkoXtXGRxTy+Q50vsz6deESKz/lQQ4Iyu8u01E@public.gmane.org>
2004-11-11  1:22                 ` Wang, Zhenyu [this message]
     [not found]                   ` <20041111012228.GA18032-/VnEId6AORcBH7GVJk7YB9h3ngVCH38I@public.gmane.org>
2004-11-11 15:26                     ` dev_zero
  -- strict thread matches above, loose matches on Subject: below --
2004-11-16  3:29 Yu, Luming
2004-11-11 16:51 Yu, Luming
2004-11-11 16:57 ` dev_zero
2004-11-11 15:32 Yu, Luming
2004-11-11 15:56 ` dev_zero
2004-11-11 16:01 ` dev_zero
2004-11-11 16:37 ` dev_zero
2004-11-11 14:37 Yu, Luming
     [not found] <3ACA40606221794F80A5670F0AF15F84041AC04B@pdsmsx403>
2004-11-10 16:14 ` dev_zero
     [not found] <3ACA40606221794F80A5670F0AF15F84041AC049@pdsmsx403>
2004-11-10 16:06 ` dev_zero
2004-11-10 16:11 ` dev_zero
     [not found] <3ACA40606221794F80A5670F0AF15F84041AC048@pdsmsx403>
2004-11-10 14:40 ` dev_zero
2004-11-10 14:50 ` dev_zero
2004-11-10 14:26 Yu, Luming
2004-11-10 14:35 ` dev_zero
     [not found] <3ACA40606221794F80A5670F0AF15F84041AC042@pdsmsx403>
2004-11-09 17:06 ` dev_zero
2004-11-09 15:50 Yu, Luming
2004-11-09 16:15 ` dev_zero
2004-11-09  8:23 Yu, Luming
2004-11-09 15:12 ` dev_zero
     [not found]   ` <20041109151244.94397.qmail-Njb8tMpsuHHGRxTy+Q50vsz6deESKz/lQQ4Iyu8u01E@public.gmane.org>
2004-11-09 15:45     ` Andrew Barr
2004-11-16  0:36 ` Laszlo 'GCS' Boszormenyi
2004-11-08  3:23 Yu, Luming
2004-11-08 20:41 ` dev_zero
2004-11-08  1:58 Yu, Luming
2004-11-08  2:48 ` Laszlo 'GCS' Boszormenyi
2004-11-08  3:18   ` Laszlo 'GCS' Boszormenyi
2004-11-05 23:38 dev_zero
     [not found] ` <418C0EFA.6000001-eZNTXLQAfP4@public.gmane.org>
2004-11-06  2:02   ` Laszlo 'GCS' Boszormenyi
2004-11-06 12:58     ` dev_zero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041111012228.GA18032@zhen-devel.sh.intel.com \
    --to=zhenyu.z.wang-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=dev_xor-eZNTXLQAfP4@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox