From: Greg KH <greg@kroah.com>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org,
Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com>,
Kay Sievers <kay.sievers@vrfy.org>,
tokunaga.keiich@jp.fujitsu.com, motoyuki@soft.fujitsu.com,
Adrian Bunk <bunk@stusta.de>, Andrew Morton <akpm@osdl.org>,
rml@novell.com, len.brown@intel.com,
acpi-devel@lists.sourceforge.net
Subject: Re: [ACPI] Re: 2.6.10-rc1-mm3: ACPI problem due to un-exported hotplug_path
Date: Mon, 15 Nov 2004 21:54:06 -0800 [thread overview]
Message-ID: <20041116055406.GG29328@kroah.com> (raw)
In-Reply-To: <200411092315.55187.dtor_core@ameritech.net>
On Tue, Nov 09, 2004 at 11:15:55PM -0500, Dmitry Torokhov wrote:
> On Tuesday 09 November 2004 07:08 pm, Greg KH wrote:
> > On Tue, Nov 09, 2004 at 06:48:17PM -0500, Dmitry Torokhov wrote:
> > > On Tue, 9 Nov 2004 14:55:02 -0800, Greg KH <greg@kroah.com> wrote:
> > > > On Fri, Nov 05, 2004 at 09:18:48PM -0800, Keshavamurthy Anil S wrote:
> > > > > Also, since you have brought this, I have one another question to you.
> > > > > Now in the new kernel, I see whenever anybody calls sysdev_register(kobj),
> > > > > an "ADD" notification is sent. why is this? I would like to call
> > > > > kobject_hotplug(kobj, ADD) later.
> > > >
> > > > This happens when kobject_add() is called. You shouldn't ever need to
> > > > call kobject_hotplug() for an add event yourself.
> > > >
> > >
> > > This is not always the case. One might want to postpone ADD event
> > > until all summpelental object attributes are created. This way userspace
> > > is presented with object in consistent state.
> >
> > No, that's a mess. Let userspace wait for those attributes to show up
> > if they need to. That's what the "wait_for_sysfs" program bundled with
> > udev is for.
> >
>
> I strongly disagree:
>
> - it makes userspace being aware of implementation details (whe exactly it
> has to wait for, for how long, etc.) which is bad thing;
> - not all the world is udev - needless replication of the code and bugs;
> - not only making visible but announcing an object in non-working state
> to userspace simply does not feel right.
Based on the recent additions to the /sbin/hotplug environment
variables, userspace now knows exactly what it needs to wait for, if
anything.
Also, there's no needless replication of this code, that's why
wait_for_sysfs was split off of udev, it's for everyone to use, if they
want to.
thanks,
greg k-h
prev parent reply other threads:[~2004-11-16 5:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041105001328.3ba97e08.akpm@osdl.org>
2004-11-05 16:45 ` 2.6.10-rc1-mm3: ACPI problem due to un-exported hotplug_path Adrian Bunk
2004-11-05 18:05 ` Greg KH
2004-11-05 20:10 ` Kay Sievers
2004-11-05 20:32 ` Ashok Raj
2004-11-05 20:43 ` Greg KH
2004-11-05 20:45 ` Kay Sievers
2004-11-05 20:42 ` Greg KH
2004-11-06 5:18 ` Keshavamurthy Anil S
2004-11-06 5:50 ` Dmitry Torokhov
[not found] ` <20041105211848.A21098-39QZ/XbsZ5/mO6KZMuUCQVaTQe2KTcn/@public.gmane.org>
2004-11-09 22:55 ` Greg KH
[not found] ` <20041109225502.GC7618-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2004-11-09 23:48 ` Dmitry Torokhov
[not found] ` <d120d5000411091548584bf8c5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2004-11-10 0:08 ` Greg KH
[not found] ` <20041110000811.GA8543-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2004-11-10 4:15 ` Dmitry Torokhov
2004-11-16 5:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041116055406.GG29328@kroah.com \
--to=greg@kroah.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=akpm@osdl.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=bunk@stusta.de \
--cc=dtor_core@ameritech.net \
--cc=kay.sievers@vrfy.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=motoyuki@soft.fujitsu.com \
--cc=rml@novell.com \
--cc=tokunaga.keiich@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox