Re: [PATCH] Don't disable interrupts during EC access

[Matthew Wilcox <matthew-Ztpu424NOJ8@public.gmane.org>]

On Tue, Nov 16, 2004 at 02:15:47PM +0800, Yu, Luming wrote:
> Andi,
> 
> This patch seems to break the atomic operation.
> The original code enclosed by spin_lock_irqsave/spin_unlock_irqresotre is trying to make sure the first operation to EC_COMMAND
> register , and the second operation to EC_DATA register belong to one atomic transaction.

Why would converting from a spinlock to a semaphore break this?

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain


-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8