From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH] Don't disable interrupts during EC access Date: Tue, 16 Nov 2004 12:16:16 +0000 Message-ID: <20041116121616.GG1108@parcelfarce.linux.theplanet.co.uk> References: <3ACA40606221794F80A5670F0AF15F84041AC076@pdsmsx403> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <3ACA40606221794F80A5670F0AF15F84041AC076@pdsmsx403> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: "Yu, Luming" Cc: Andi Kleen , acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, "Fu, Michael" List-Id: linux-acpi@vger.kernel.org On Tue, Nov 16, 2004 at 02:15:47PM +0800, Yu, Luming wrote: > Andi, > > This patch seems to break the atomic operation. > The original code enclosed by spin_lock_irqsave/spin_unlock_irqresotre is trying to make sure the first operation to EC_COMMAND > register , and the second operation to EC_DATA register belong to one atomic transaction. Why would converting from a spinlock to a semaphore break this? -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain ------------------------------------------------------- This SF.Net email is sponsored by: InterSystems CACHE FREE OODBMS DOWNLOAD - A multidimensional database that combines robust object and relational technologies, making it a perfect match for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8