public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bruno Ducrot <ducrot-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>
To: giupil <giupil-nznwD2ikctv02BlrwmTdfg@public.gmane.org>
Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: Aspire 1511LMI - Aspire 1513LMI DSDT
Date: Mon, 22 Nov 2004 15:15:49 +0100	[thread overview]
Message-ID: <20041122141549.GI31422@poupinou.org> (raw)
In-Reply-To: <41A1F973.7060700-nznwD2ikctv02BlrwmTdfg@public.gmane.org>

On Mon, Nov 22, 2004 at 02:36:35PM +0000, giupil wrote:
> Hi Bruno,
> 
> I'm sorry for my ignorance, I'm not a expert. I'm very gratefull for 
> your notes.
> The only problem that still remains in my mind is:
> 
>   In
>  
>   http://acpi.sourceforge.net/dsdt/tables/ACER/Aspire_1513LMi/-
>   ACER-Aspire_1513LMi-unknown_bios-custom.asl.gz
>  
>   at the line 3893 of the ACER-Aspire_1513LMi-unknown_bios-custom.dsl 
> decompiled file, I
>   find:
> 
>                    Return (Package (0x02)
>                    {
>                            Zero,
>                            Zero
>                     })
> 
>    but at the 
> http://casteyde.christian.free.fr/laptop/LinuxOnAspire1511LMi.html in the
>    dsdt_asp1511.asl at the line 3895, I find:
> 
> 
>                    Return (0x00)
> 
>    These corrections are about the warnig:
> 
>    mydsdt_orig.dsl  3865:                     Method (DRUL, 1, 
> NotSerialized)
>    Warning  2019 -                              ^ Not all control paths 
> return a value (DRUL)

The other paths return an integer, and this is not a reserved method.
So return an integer ;)

I would buy for 'Return (0)', but anyway I will not care for this at
all, since it's called only in order to query a VGA change via probably
a hotkey at first read (via a _Q?? method), and there is
nothing to verify the return values anyway in the AML.


-- 
Bruno Ducrot

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

      parent reply	other threads:[~2004-11-22 14:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-19 20:03 Aspire 1511LMI - Aspire 1513LMI DSDT giupil
     [not found] ` <419E5183.6030405-nznwD2ikctv02BlrwmTdfg@public.gmane.org>
2004-11-19 20:01   ` Bruno Ducrot
     [not found]     ` <20041119200129.GG31422-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>
2004-11-22 14:36       ` giupil
     [not found]         ` <41A1F973.7060700-nznwD2ikctv02BlrwmTdfg@public.gmane.org>
2004-11-22 14:15           ` Bruno Ducrot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041122141549.GI31422@poupinou.org \
    --to=ducrot-kk6yzipjem5g9huczpvpmw@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=giupil-nznwD2ikctv02BlrwmTdfg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox