Re: Shutting down PCI devices on suspend

[ambx1-IBH0VoN/3vPQT0dZR+AlfA@public.gmane.org (Adam Belay)]

On Sun, Dec 12, 2004 at 06:15:21PM +0100, Pavel Machek wrote:
> Hi!
> 
> > > Please do it in the drivers. Anything else is likely to break
> > > currently working setups.

I agree.  However there may be other strategies to explore.

> > 
> > This requires a driver for every PCI device on the system. Is this the
> > best solution?
> 
> Each PCI device is either:
> 
> * supported -- it has a driver, we are okay
> 
> * unsupported -- it should not be even turned on, right?
> 
> * legacy, like VGA or IDE -- okay, we need drivers for those. You need
> to reinit them on resume, anyway, so....
> 
> ...yes, I think this is the best solution.
> 								Pavel
> -- 

Not necessarily.  Most unsupported devices start in the on state.  Also I
think it's difficult to see a consistent power management behavior/policy if
each driver is controlling it's devices' power state.  I'd prefer to have
drivers saving and restoring device state and then having the bus driver
take care of the actual power state transitions.

Thanks,
Adam


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/