Re: Re: [PATCHES] add _CST support

Dominik Brodowski
2004-12-23T00:08:42Z

On Wed, Dec 22, 2004 at 12:44:05AM -0500, Len Brown wrote:
> On Sat, 2004-11-27 at 16:51, Dominik Brodowski wrote:
>
> > - make acpi_cstate_limit aware of c-state types instead of numbers, as the
> > latter mean (almost) nothing
>
> While both C3 and C4 will be of type-C3, I'd like to still be able to
> disable C4 without disabling C3.

If we can agree not to call it "C3" and "C4", yes... The problem is the
C-nomination is sort of a _type_ which is overloaded with the actual states.
I.e. you could have C0 state, C1 state, 2 different C2 states, and 2
different C3 states. Then you'd have

number type overloaded C-notation

0 C0 C0
1 C1 C1
2 C2 C2
3 C2 C3 <--- confusion/breakage
4 C3 C4
5 C3 C5

Also, drivers like the ipw driver will want to disable all of _type_ C3
sleep, AFAICS. Therefore, if you want to limit it by number instead of type
as well, I'd suggest to add another differently named parameter.

Dominik