Re: [PATCHES] add _CST support

Len Brown
2004-12-22T06:52:12Z

On Sat, 2004-11-27 at 16:51, Dominik Brodowski wrote:
> On top of the processor.c splitup patchset announced earlier today I've
> rediffed, modified and split up the _CST patches originally developed by Bruno Ducrot
> (i.e. the static approach, not my broken dynamic patch) and tracked at
> http://bugme.osdl.org/show_bug.cgi?id=1958 .
>
> A "bigdiff" which should apply cleanly on top of 2.6.10-rc2-mm3 is available at
> http://www.brodo.de/patches/2004-11-27/01-acpi-20041127-complete (~176KB)
> and zipped
> http://www.brodo.de/patches/2004-11-27/01-acpi-20041127-complete (~36KB)
>
> To apply the following individual patches, you first need the processor.c splitup patches:
> http://www.brodo.de/patches/2004-11-27/01-acpi-20041127-processor-splitup-perflib
> http://www.brodo.de/patches/2004-11-27/02-acpi-20041127-processor-splitup-throttling
> http://www.brodo.de/patches/2004-11-27/03-acpi-20041127-processor-splitup-idle
> http://www.brodo.de/patches/2004-11-27/04-acpi-20041127-processor-splitup-thermal
> http://www.brodo.de/patches/2004-11-27/05-acpi-20041127-processor-splitup-core
> http://www.brodo.de/patches/2004-11-27/06-acpi-20041127-throttling-disableirqsforshorterperiods
>
> Please test + apply,
> Dominik

Applied to 26-latest-test tree.
(did not back-port to the 2.6.9-based 26-stable-test tree)

I found I had to disable the bm_check to get out of C1
on my D600. This doesn't sound right, as bm_check
should only have an effect on entering C3.

I used options processor max_cstate=42
in /etc/modprobe.conf to make sure this
value defaulting to 3 isn't an issue,
but still unable to get into C4:

cat /proc/acpi/processor/CPU0/power
active state: 3
max_cstate: C42
bus master activity: 00000000
states:
1: type[C1] promotion[2] demotion[-] latency[001]
usage[00000010]
2: type[C2] promotion[3] demotion[1] latency[001]
usage[00003280]
*3: type[C3] promotion[4] demotion[2] latency[085]
usage[00000819]
4: type[C3] promotion[-] demotion[2] latency[185]
usage[00000000]

It appears the demotion from C4 is to C2, when one would expect C3.

thanks,
-Len

ps. I've seen an issue with the refernece count on processor
module reaching 2 and prevening unloading, but haven't isolated it yet.