Re: Re: [PATCHES] add _CST support

Pavel Machek
2004-12-23T13:07:23Z

Hi!

> > > > - make acpi_cstate_limit aware of c-state types instead of
> > numbers, as the latter mean (almost) nothing
> > >
> > > While both C3 and C4 will be of type-C3, I'd like to still be able
> > to disable C4 without disabling C3.
> >
> > If we can agree not to call it "C3" and "C4", yes... The problem is
> > the C-nomination is sort of a _type_ which is overloaded with the
> > actual states.
>
> C-states are enumerated C0...Cn
> C-state types are enumerated C1, C2, C3.
> I don't see any confusion in the name-space duplicates
> as long as you know you're talking about C-states or C-state-types.
>

Unfortunately, people often don't know what they are talking about.
Having two things called C2 is definitely going to confuse just
about everyone but you...

Can't you #define C2type 2 or something? There has to be better
name for all this.
Pavel
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms