Re: [PATCH 4/4]An ACPI callback for pci_set_power_state

Pavel Machek
2005-01-05T08:49:54Z

Hi!

> This is an ACPI callback for pci_set_power_state. Besides setting PCI
> config space, changing device's power state sometimes requires to power
> on device's power source and to invoke other firmware methods.

> diff -puN drivers/pci/pci.h~acpi-pci-set-power-state-callback drivers/pci/pci.h
> --- 2.5/drivers/pci/pci.h~acpi-pci-set-power-state-callback 2005-01-05 09:58:06.469923128 +0800
> +++ 2.5-root/drivers/pci/pci.h 2005-01-05 09:58:06.473922520 +0800
> @@ -13,6 +13,7 @@ extern int pci_bus_alloc_resource(struct
> void *alignf_data);
> /* Firmware callbacks */
> extern int (*platform_pci_get_suspend_state)(struct device *dev, u32 state);
> +extern int (*platform_pci_set_power_state)(struct pci_dev *dev, int state);

What kind of state is passed here? Why is it u32 in one case and int
in the second one?

I'm about to introduce separate types for pci power states and system
power states; could you at least add comments which states are which?
Also few lines of documentation would be very usefull...

Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!