From: Pavel Machek <pavel@suse.cz>
To: Li Shaohua <shaohua.li@intel.com>
Cc: Len Brown <len.brown@intel.com>,
ACPI Developers <acpi-devel@lists.sourceforge.net>,
lkml <linux-kernel@vger.kernel.org>, Greg <greg@kroah.com>,
Patrick Mochel <mochel@digitalimplant.org>,
Adam Belay <ambx1@neo.rr.com>
Subject: Re: [PATCH 0/4]Bind physical devices with ACPI devices - take 2
Date: Thu, 6 Jan 2005 10:57:31 +0100 [thread overview]
Message-ID: <20050106095731.GE24380@elf.ucw.cz> (raw)
In-Reply-To: <1104997834.22886.17.camel@sli10-desk.sh.intel.com>
Hi!
> > It looks like some device drivers scribble on dev->platform_data;
> > and we need to fix those drivers before deploying this patch.
> > Alternatively, we could add a new field to struct device,
> > but then we'd probably never get rid of it...
> Yep, this is a big problem. According to the comments in the source
> file, it's designed for firmware such as ACPI, but some drivers misused
> it. A search shows there are many such drivers. Fixing the drivers is a
> pain for me.
It is easy: remove the field for release or two, then readd it with
your patch.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2005-01-06 9:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-05 2:50 [PATCH 0/4]Bind physical devices with ACPI devices - take 2 Li Shaohua
2005-01-06 4:00 ` Len Brown
2005-01-06 7:50 ` Li Shaohua
2005-01-06 9:57 ` Pavel Machek [this message]
[not found] ` <1104893444.5550.127.camel-U5EdaLXB8smDugQYiPIPGdh3ngVCH38I@public.gmane.org>
2005-01-17 7:57 ` Li Shaohua
2005-01-17 11:28 ` Pavel Machek
[not found] ` <20050117112822.GA1354-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-01-18 1:20 ` Li Shaohua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050106095731.GE24380@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=acpi-devel@lists.sourceforge.net \
--cc=ambx1@neo.rr.com \
--cc=greg@kroah.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox