[PATCH] Sanitize ACPI Kconfig

[PATCH] Sanitize ACPI Kconfig

[Andi Kleen]

Sanitize ACPI Kconfig. No other subsystem uses default m for all its
options and surely there is no need to do this for the more obscure
modules. When you do make oldconfig with an old option and just press
return you tend to get a lot of modules you don't want with this. 
Normally new stuff is off by default.

I added default y for the processor driver which is important
for power saving, and for the others the user can decide but 
the default is off.

Also give a useful default for the cutoff year.

Signed-off-by: Andi Kleen <ak-l3A5Bk7waGM@public.gmane.org>

diff -u linux-2.6.10-bk6/drivers/acpi/Kconfig-o linux-2.6.10-bk6/drivers/acpi/Kconfig
--- linux-2.6.10-bk6/drivers/acpi/Kconfig-o	2005-01-04 12:15:18.000000000 +0100
+++ linux-2.6.10-bk6/drivers/acpi/Kconfig	2005-01-04 13:44:00.000000000 +0100
@@ -82,7 +82,6 @@
 	tristate "AC Adapter"
 	depends on X86
 	depends on ACPI_INTERPRETER
-	default m
 	help
 	  This driver adds support for the AC Adapter object, which indicates
 	  whether a system is on AC, or not.  Typically, only mobile systems 
@@ -92,7 +91,6 @@
 	tristate "Battery"
 	depends on X86
 	depends on ACPI_INTERPRETER
-	default m
 	help
 	  This driver adds support for battery information through
 	  /proc/acpi/battery. If you have a mobile system with a battery, 
@@ -102,7 +100,6 @@
 	tristate "Button"
 	depends on ACPI_INTERPRETER
 	depends on !IA64_SGI_SN
-	default m
 	help
 	  This driver registers for events based on buttons, such as the
 	  power, sleep, and lid switch.  In the future, a daemon will read
@@ -115,7 +112,6 @@
 	depends on ACPI_INTERPRETER
 	depends on EXPERIMENTAL
 	depends on !IA64_SGI_SN
-	default m
 	help
 	  This driver implement the ACPI Extensions For Display Adapters
 	  for integrated graphics devices on motherboard, as specified in
@@ -129,7 +125,6 @@
 	tristate "Fan"
 	depends on ACPI_INTERPRETER
 	depends on !IA64_SGI_SN
-	default m
 	help
 	  This driver adds support for ACPI fan devices, allowing user-mode 
 	  applications to perform basic fan control (on, off, status).
@@ -138,7 +133,7 @@
 	tristate "Processor"
 	depends on ACPI_INTERPRETER
 	depends on !IA64_SGI_SN
-	default m
+	default y
 	help
 	  This driver installs ACPI as the idle handler for Linux, and uses
 	  ACPI C2 and C3 processor states to save power, on systems that
@@ -156,7 +151,7 @@
 config ACPI_THERMAL
 	tristate "Thermal Zone"
 	depends on ACPI_PROCESSOR
-	default m
+	default y
 	help
 	  This driver adds support for ACPI thermal zones.  Most mobile and
 	  some desktop systems support ACPI thermal zones.  It is HIGHLY
@@ -174,7 +169,6 @@
         tristate "ASUS/Medion Laptop Extras"
 	depends on X86
 	depends on ACPI_INTERPRETER
-	default m
         ---help---
           This driver provides support for extra features of ACPI-compatible
           ASUS laptops. As some of Medion laptops are made by ASUS, it may also
@@ -204,7 +198,6 @@
 	tristate "IBM ThinkPad Laptop Extras"
 	depends on X86
 	depends on ACPI_INTERPRETER
-	default m
 	---help---
 	  This is a Linux ACPI driver for the IBM ThinkPad laptops. It adds
 	  support for Fn-Fx key combinations, Bluetooth control, video
@@ -218,7 +211,6 @@
 	tristate "Toshiba Laptop Extras"
 	depends on X86
 	depends on ACPI_INTERPRETER
-	default m
 	---help---
 	  This driver adds support for access to certain system settings
 	  on "legacy free" Toshiba laptops.  These laptops can be recognized by
@@ -259,7 +251,7 @@
 
 config ACPI_BLACKLIST_YEAR
 	int "Disable ACPI for systems before Jan 1st this year"
-	default 0
+	default 2001
 	help
 	  enter a 4-digit year, eg. 2001 to disable ACPI by default
 	  on platforms with DMI BIOS date before January 1st that year.


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Re: [PATCH] Sanitize ACPI Kconfig

[David Goodenough]

There are several ACPI BIOS's with dates before 2001 which work quite
happily.  You are condeming people who do not want to have to rebuild
their kernel to have ACPI disabled.  

I also think that having a few redundant modules around really does not hurt.  

There seems to be a presumption amongst those who maintain ACPI that
the world rebuilds their kernels.  Look at the DSDT over-ride issue, the 
"official" way is to rebuild your kernel, the derided method is to append
the DSDT to the initrd.  This means that those with buggy DSDTs HAVE
to build their own kernels as they can not use stock ones.  

If we want Linux to become pervasive we have to make it easy to use,
and forcing Joe-User to build their own kernels is a very quick way to 
stop them using Linux.  Joe-User needs a stock kernel.

David

On Friday 07 January 2005 21:22, Andi Kleen wrote:
> Sanitize ACPI Kconfig. No other subsystem uses default m for all its
> options and surely there is no need to do this for the more obscure
> modules. When you do make oldconfig with an old option and just press
> return you tend to get a lot of modules you don't want with this.
> Normally new stuff is off by default.
>
> I added default y for the processor driver which is important
> for power saving, and for the others the user can decide but
> the default is off.
>
> Also give a useful default for the cutoff year.
>
> Signed-off-by: Andi Kleen <ak-l3A5Bk7waGM@public.gmane.org>
>
> diff -u linux-2.6.10-bk6/drivers/acpi/Kconfig-o
> linux-2.6.10-bk6/drivers/acpi/Kconfig ---
> linux-2.6.10-bk6/drivers/acpi/Kconfig-o 2005-01-04 12:15:18.000000000 +0100
> +++ linux-2.6.10-bk6/drivers/acpi/Kconfig 2005-01-04 13:44:00.000000000
> +0100 @@ -82,7 +82,6 @@
>   tristate "AC Adapter"
>   depends on X86
>   depends on ACPI_INTERPRETER
> - default m
>   help
>     This driver adds support for the AC Adapter object, which indicates
>     whether a system is on AC, or not.  Typically, only mobile systems
> @@ -92,7 +91,6 @@
>   tristate "Battery"
>   depends on X86
>   depends on ACPI_INTERPRETER
> - default m
>   help
>     This driver adds support for battery information through
>     /proc/acpi/battery. If you have a mobile system with a battery,
> @@ -102,7 +100,6 @@
>   tristate "Button"
>   depends on ACPI_INTERPRETER
>   depends on !IA64_SGI_SN
> - default m
>   help
>     This driver registers for events based on buttons, such as the
>     power, sleep, and lid switch.  In the future, a daemon will read
> @@ -115,7 +112,6 @@
>   depends on ACPI_INTERPRETER
>   depends on EXPERIMENTAL
>  	depends on !IA64_SGI_SN
> -	default m
>  	help
>  	  This driver implement the ACPI Extensions For Display Adapters
>  	  for integrated graphics devices on motherboard, as specified in
> @@ -129,7 +125,6 @@
>  	tristate "Fan"
>  	depends on ACPI_INTERPRETER
>  	depends on !IA64_SGI_SN
> -	default m
>  	help
>  	  This driver adds support for ACPI fan devices, allowing user-mode
>  	  applications to perform basic fan control (on, off, status).
> @@ -138,7 +133,7 @@
>  	tristate "Processor"
>  	depends on ACPI_INTERPRETER
>  	depends on !IA64_SGI_SN
> -	default m
> +	default y
>  	help
>  	  This driver installs ACPI as the idle handler for Linux, and uses
>  	  ACPI C2 and C3 processor states to save power, on systems that
> @@ -156,7 +151,7 @@
>  config ACPI_THERMAL
>  	tristate "Thermal Zone"
>  	depends on ACPI_PROCESSOR
> -	default m
> +	default y
>  	help
>  	  This driver adds support for ACPI thermal zones.  Most mobile and
>  	  some desktop systems support ACPI thermal zones.  It is HIGHLY
> @@ -174,7 +169,6 @@
>          tristate "ASUS/Medion Laptop Extras"
>  	depends on X86
>  	depends on ACPI_INTERPRETER
> -	default m
>          ---help---
>            This driver provides support for extra features of
> ACPI-compatible ASUS laptops. As some of Medion laptops are made by ASUS,
> it may also @@ -204,7 +198,6 @@
>  	tristate "IBM ThinkPad Laptop Extras"
>  	depends on X86
>  	depends on ACPI_INTERPRETER
> -	default m
>  	---help---
>  	  This is a Linux ACPI driver for the IBM ThinkPad laptops. It adds
>  	  support for Fn-Fx key combinations, Bluetooth control, video
> @@ -218,7 +211,6 @@
>  	tristate "Toshiba Laptop Extras"
>  	depends on X86
>  	depends on ACPI_INTERPRETER
> -	default m
>  	---help---
>  	  This driver adds support for access to certain system settings
>  	  on "legacy free" Toshiba laptops.  These laptops can be recognized by
> @@ -259,7 +251,7 @@
>
>  config ACPI_BLACKLIST_YEAR
>  	int "Disable ACPI for systems before Jan 1st this year"
> -	default 0
> +	default 2001
>  	help
>  	  enter a 4-digit year, eg. 2001 to disable ACPI by default
>  	  on platforms with DMI BIOS date before January 1st that year.
>
>
> -------------------------------------------------------
> The SF.Net email is sponsored by: Beat the post-holiday blues
> Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
> It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Re: [PATCH] Sanitize ACPI Kconfig

[Pavel Machek]

Hi!

> Sanitize ACPI Kconfig. No other subsystem uses default m for all its
> options and surely there is no need to do this for the more obscure
> modules. When you do make oldconfig with an old option and just press
> return you tend to get a lot of modules you don't want with this. 
> Normally new stuff is off by default.

I'd say that AC adapter, battery, button and fan should be on by
default. You set thermal zone to on by default, but thermal zone
without fan seems like bad idea (not totally useless, but you usually
want fans for thermal managment). Everybody uses battery (actually it
seems to be single most important feature). And AC adapter is
neccessary if you want to go 2GHz with your athlon64 laptop (or it is
800MHz), so I'd say enable it.
								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Re: [PATCH] Sanitize ACPI Kconfig

[Andi Kleen]

On Mon, Jan 17, 2005 at 01:11:50AM +0100, Pavel Machek wrote:
> Hi!
> 
> > Sanitize ACPI Kconfig. No other subsystem uses default m for all its
> > options and surely there is no need to do this for the more obscure
> > modules. When you do make oldconfig with an old option and just press
> > return you tend to get a lot of modules you don't want with this. 
> > Normally new stuff is off by default.
> 
> I'd say that AC adapter, battery, button and fan should be on by
> default. You set thermal zone to on by default, but thermal zone
> without fan seems like bad idea (not totally useless, but you usually
> want fans for thermal managment). Everybody uses battery (actually it
> seems to be single most important feature). And AC adapter is

For a rather small value of "everybody".

> neccessary if you want to go 2GHz with your athlon64 laptop (or it is
> 800MHz), so I'd say enable it.

My desktop boxes and servers all don't care about battery or AC.

But I'm not opposed to turning it on, just the "m" default is quite useless.

-Andi



-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Re: [PATCH] Sanitize ACPI Kconfig

[Pavel Machek]

Hi!

> > > Sanitize ACPI Kconfig. No other subsystem uses default m for all its
> > > options and surely there is no need to do this for the more obscure
> > > modules. When you do make oldconfig with an old option and just press
> > > return you tend to get a lot of modules you don't want with this. 
> > > Normally new stuff is off by default.
> > 
> > I'd say that AC adapter, battery, button and fan should be on by
> > default. You set thermal zone to on by default, but thermal zone
> > without fan seems like bad idea (not totally useless, but you usually
> > want fans for thermal managment). Everybody uses battery (actually it
> > seems to be single most important feature). And AC adapter is
> 
> For a rather small value of "everybody".

Ok, every notebook.

> > neccessary if you want to go 2GHz with your athlon64 laptop (or it is
> > 800MHz), so I'd say enable it.
> 
> My desktop boxes and servers all don't care about battery or AC.
> 
> But I'm not opposed to turning it on, just the "m" default is quite useless.

I'd say that 'y' there makes sense, but anything is better than 'm'.

									Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Re: [PATCH] Sanitize ACPI Kconfig

[David Goodenough]

On Monday 17 January 2005 11:30, Pavel Machek wrote:
> Hi!
>
> > > > Sanitize ACPI Kconfig. No other subsystem uses default m for all its
> > > > options and surely there is no need to do this for the more obscure
> > > > modules. When you do make oldconfig with an old option and just press
> > > > return you tend to get a lot of modules you don't want with this.
> > > > Normally new stuff is off by default.
> > >
> > > I'd say that AC adapter, battery, button and fan should be on by
> > > default. You set thermal zone to on by default, but thermal zone
> > > without fan seems like bad idea (not totally useless, but you usually
> > > want fans for thermal managment). Everybody uses battery (actually it
> > > seems to be single most important feature). And AC adapter is
> >
> > For a rather small value of "everybody".
>
> Ok, every notebook.
>
> > > neccessary if you want to go 2GHz with your athlon64 laptop (or it is
> > > 800MHz), so I'd say enable it.
> >
> > My desktop boxes and servers all don't care about battery or AC.
> >
> > But I'm not opposed to turning it on, just the "m" default is quite
> > useless.
>
> I'd say that 'y' there makes sense, but anything is better than 'm'.
I really do not understand this.  Having is as a module wastes a bit of disk
space (usually not a problem) but means that they can be loaded if wanted
either by loading them manually or by using acpid.  Having them as y forces
them to be there and some systems with dodgy ACPI implementations will
have problems, and having them not there means that Joe User has to 
recompile his stock kernel (he probably does not even know that the kernel
exists, let along that he can rebuild it, let alone how to) in order to use
ACPI.  Don't you want Joe User to use ACPI?

David
>
>          Pavel


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Re: [PATCH] Sanitize ACPI Kconfig

[Pavel Machek]

Hi!

> > > > neccessary if you want to go 2GHz with your athlon64 laptop (or it is
> > > > 800MHz), so I'd say enable it.
> > >
> > > My desktop boxes and servers all don't care about battery or AC.
> > >
> > > But I'm not opposed to turning it on, just the "m" default is quite
> > > useless.
> >
> > I'd say that 'y' there makes sense, but anything is better than 'm'.
> I really do not understand this.  Having is as a module wastes a bit of disk
> space (usually not a problem) but means that they can be loaded if wanted
> either by loading them manually or by using acpid.  Having them as y forces
> them to be there and some systems with dodgy ACPI implementations will
> have problems, and having them not there means that Joe User has to 

We want to get maximum testing. If there's some dodgy machine, we want
to have it fixed. [I do not believe I seen such dodgy machines in
recent history.]
								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Re: [PATCH] Sanitize ACPI Kconfig

[David Goodenough]

On Wednesday 19 January 2005 12:15, Pavel Machek wrote:
> Hi!
>
> > > > > neccessary if you want to go 2GHz with your athlon64 laptop (or it
> > > > > is 800MHz), so I'd say enable it.
> > > >
> > > > My desktop boxes and servers all don't care about battery or AC.
> > > >
> > > > But I'm not opposed to turning it on, just the "m" default is quite
> > > > useless.
> > >
> > > I'd say that 'y' there makes sense, but anything is better than 'm'.
> >
> > I really do not understand this.  Having is as a module wastes a bit of
> > disk space (usually not a problem) but means that they can be loaded if
> > wanted either by loading them manually or by using acpid.  Having them as
> > y forces them to be there and some systems with dodgy ACPI
> > implementations will have problems, and having them not there means that
> > Joe User has to
>
> We want to get maximum testing. If there's some dodgy machine, we want
> to have it fixed. [I do not believe I seen such dodgy machines in
> recent history.]
>         Pavel
I think you will find that many people are still using APM because they do not
trust ACPI on their machines.  This may be misplaced but forcing ACPI to be
built always may be misunderstood by those people.

David


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl

Re: [PATCH] Sanitize ACPI Kconfig

[Pavel Machek]

Hi!

> > We want to get maximum testing. If there's some dodgy machine, we want
> > to have it fixed. [I do not believe I seen such dodgy machines in
> > recent history.]
> >         Pavel
> I think you will find that many people are still using APM because they do not
> trust ACPI on their machines.  This may be misplaced but forcing ACPI to be
> built always may be misunderstood by those people.

I'm not talking about forcing people to do anything, we were talking
about defconfig, only.
								Pavel

-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl