Re: Re: first shoot for smartbattery

Bruno Ducrot
2005-01-04T10:08:44Z

On Mon, Jan 03, 2005 at 07:50:13PM +0000, Pedro Venda wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Bruno Ducrot wrote:
> | On Mon, Jan 03, 2005 at 05:35:13PM +0000, Pedro Venda wrote:
> |
> |>-----BEGIN PGP SIGNED MESSAGE-----
> |>Hash: SHA1
> |>
> |>Pedro Venda wrote:
> |>| Bruno Ducrot wrote:
> |>|
> |>| | I think I found was wrong. Please refetch, or (at your option)
> replace
> |>| | i2c-acpi-ec.ec with
> |>| |
> |>|
> http://www.poupinou.org/acpi/smartbatt/smartbatt/i2c-acpi-ec/i2c-acpi-ec.c
> |>| | then redo the sh compile.sh
> |>| | Sorry, it was a stupid bug(tm) requiring that I buy a brown bag...
> |>|
> |>| happens to everyone.
> |>|
> |>| | Something wrong also with rmmod i2c-acpi-ec :( so you have to reboot
> in
> |>| | order to be able to 'insmod i2c-acpi-ec.ko' again (I'm sure the brown
> |>| | bag will still be helpfull also...).
> |>
> |>ok I made a small patch against your most recent code base:
> |
> |
> | Thanks.
> |
> |
> |>included:
> |>- - a Makefile for the i2c-acpi-ec module
> |>- - a Makefile for the smartbattery program which also calls the
> |>i2c-acpi-ec make
> |>process.
> |>
> |>in the smartbattery directory, one just "make"s and everything gets built.
> |
> |
> | Ok.
>
> another thing: I changed the current drain from "mA or mWh" to "mAh or mW"
> in
> smartbattery.c but I'm having some doubts:

It's mAh or mWh, depending of the value of CAPACITY_MODE. This is a r/w
bit in BatteryMode() word (the 15th). If this bit is clear (default),
then it is mAh and this is current in mAh. If this bit is set, this
power, exprimed as 10mWh.

I've fixed this issue. Hopefully it should be ok now.

--
Bruno Ducrot

-- Which is worse: ignorance or apathy?
-- Don't know. Don't care.