* thermal: tell user when something goes very wrong
@ 2005-01-12 13:26 Pavel Machek
0 siblings, 0 replies; only message in thread
From: Pavel Machek @ 2005-01-12 13:26 UTC (permalink / raw)
To: Len Brown, ACPI mailing list
Hi!
This informs user when turning fan on/off helps. It also does not
retry playing with fan: on evo nx560c this lead to ugly loop in acpi
trying to turn it on over and over and over and over... Please apply,
Signed-off-by: Pavel Machek <pavel-AlSwsSmVLrQ@public.gmane.org>
Pavel
--- clean/drivers/acpi/thermal.c 2005-01-12 11:07:39.000000000 +0100
+++ linux/drivers/acpi/thermal.c 2005-01-12 11:12:02.000000000 +0100
@@ -612,8 +625,7 @@
for (j = 0; j < active->devices.count; j++) {
result = acpi_bus_set_power(active->devices.handles[j], ACPI_STATE_D0);
if (result) {
- ACPI_DEBUG_PRINT((ACPI_DB_WARN, "Unable to turn cooling device [%p] 'on'\n", active->devices.handles[j]));
- continue;
+ printk(KERN_ERR "Unable to turn cooling device [%p] 'on'\n", active->devices.handles[j]);
}
active->flags.enabled = 1;
ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Cooling device [%p] now 'on'\n", active->devices.handles[j]));
@@ -630,8 +642,7 @@
for (j = 0; j < active->devices.count; j++) {
result = acpi_bus_set_power(active->devices.handles[j], ACPI_STATE_D3);
if (result) {
- ACPI_DEBUG_PRINT((ACPI_DB_WARN, "Unable to turn cooling device [%p] 'off'\n", active->devices.handles[j]));
- continue;
+ printk(KERN_ERR "Unable to turn cooling device [%p] 'off'\n", active->devices.handles[j]);
}
active->flags.enabled = 0;
ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Cooling device [%p] now 'off'\n", active->devices.handles[j]));
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-01-12 13:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-12 13:26 thermal: tell user when something goes very wrong Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox