Re: [PATCH 0/3]making ACPICA safe for suspend/resume - take 2

[Pavel Machek <pavel-AlSwsSmVLrQ@public.gmane.org>]

Hi!

> > > The patches are designed to solve the issue of making call to ACPICA
> > > safe for suspend/resume time. Please see the detail in
> > > http://sourceforge.net/mailarchive/forum.php?thread_id=6378210&forum_id=6102
> > > The new patches remove PCI link device resume code and let PCI device
> > > driver resume code indirectly reconfigure Link's IRQ (call
> > > pci_enable_device), so we will haven't an issue of invoking ACPICA with
> > > interrupt disabled. This also works for suspend to disk case. After this
> > > we only need to guarantee there is enough free memory for S3. One
> > > problem of the idea is we must fix many PCI drivers, but it's ok to me.
> > 
> > Well, having to modify all the drivers should mean "this should be
> > merged after 2.6.11" (I'm in process of converting all the drivers to
> > pm_message_t, and would prefer another set of "touch all drivers"
> > changes not to interfere).
> There isn't conflict between the pm_message_t converting and adding
> pci_enable/disable_device to me. It would be better we do them in the
> meantime, so we don't require another round of change. If so, I can help
> doing the converting also.

Well, when something breaks, we will not know "what was it". Plus, it
is going to be quite an intrusive change and we are already at -rc2.

If driver can do pci_enable_device to solve "ACPICA with interrupts
disabled" problem, why can't be the same done in code that calls
device's suspend() method from PCI code? That would be smaller change,
and we would not duplicate a lot of code.

								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl