From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 0/3]making ACPICA safe for suspend/resume - take 2 Date: Thu, 27 Jan 2005 09:03:13 +0100 Message-ID: <20050127080313.GA5749@elf.ucw.cz> References: <1106293737.19407.60.camel@sli10-desk.sh.intel.com> <20050121095219.GA18373@elf.ucw.cz> <1106704432.5756.11.camel@sli10-desk.sh.intel.com> <20050126115804.GC10264@elf.ucw.cz> <1106787682.9062.7.camel@sli10-desk.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1106787682.9062.7.camel-U5EdaLXB8smDugQYiPIPGdh3ngVCH38I@public.gmane.org> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Li Shaohua Cc: ACPI-DEV , Len Brown , Nigel Cunningham List-Id: linux-acpi@vger.kernel.org Hi! > > why can't be the same done in code that calls > > device's suspend() method from PCI code? That would be smaller change, > > and we would not duplicate a lot of code. > This is good for pci_disable_device (suspend), but not for resume. We > must restore PCI config and then call pci_enable_device. Ok, perhaps we need pci_resume_device() wrapper, then, which does pci_restore_config() now, but we can easily add pci_enable_device() there? Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! ------------------------------------------------------- This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl