From: Pavel Machek <pavel@suse.cz>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, barryn@pobox.com,
marado@student.dei.uc.pt,
"Eric W. Biederman" <ebiederm@xmission.com>,
acpi-devel@lists.sourceforge.net, Len Brown <len.brown@intel.com>
Subject: Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown
Date: Tue, 1 Mar 2005 11:54:48 +0100 [thread overview]
Message-ID: <20050301105448.GG1345@elf.ucw.cz> (raw)
In-Reply-To: <20050301015231.091b5329.akpm@osdl.org>
Hi!
> > In `subj` kernel, machine no longer powers down at the end of
> > swsusp. 2.6.11-rc5-pavel works ok, as does 2.6.11-bk.
>
> Binary searching indicates that this is due to
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc5/2.6.11-rc5-mm1/broken-out/acpi_power_off-bug-fix.patch.
>
> I'll drop it. That patch is pretty ugly-looking anyway (ACPI code in
> drivers/base/power/?).
>
> Perhaps someone who is hitting the problem which that patch addresses could
> raise a bugzilla entry.
>
> Oh. It has one. http://bugme.osdl.org/show_bug.cgi?id=4041
>
> Anyway. It needs more work.
Yes, the patch is very ugly. If something like this needs to be done,
then perhaps acpi should properly register into driver model and do
the work there. This will also mean code will be called consistently.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2005-03-01 10:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050228231721.GA1326@elf.ucw.cz>
[not found] ` <20050228231721.GA1326-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-01 9:52 ` 2.6.11-rc4-mm1: something is wrong with swsusp powerdown Andrew Morton
2005-03-01 10:54 ` Pavel Machek [this message]
[not found] ` <20050301105448.GG1345-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-01 11:12 ` Eric W. Biederman
2005-03-01 12:02 ` Pavel Machek
2005-03-01 11:08 ` Eric W. Biederman
2005-03-01 12:08 ` Pavel Machek
2005-03-01 17:33 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050301105448.GG1345@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=acpi-devel@lists.sourceforge.net \
--cc=akpm@osdl.org \
--cc=barryn@pobox.com \
--cc=ebiederm@xmission.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marado@student.dei.uc.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox