Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

Pavel Machek
2005-03-01T12:08:43Z

Hi!

> > > In `subj` kernel, machine no longer powers down at the end of
> > > swsusp. 2.6.11-rc5-pavel works ok, as does 2.6.11-bk.
> >
> > Binary searching indicates that this is due to
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc5/2.6.11-rc5-mm1/broken-out/acpi_power_off-bug-fix.patch.
> >
> >
> > I'll drop it. That patch is pretty ugly-looking anyway (ACPI code in
> > drivers/base/power/?).
> >
> > Perhaps someone who is hitting the problem which that patch addresses could
> > raise a bugzilla entry.
> >
> > Oh. It has one. http://bugme.osdl.org/show_bug.cgi?id=4041
> >
> > Anyway. It needs more work.
>
> Agreed.
>
> I threw it together to test a specific code path, and the fact it
> fails in software suspend is actually almost confirmation that I am on
> the right track. This actually fixed the case I was testing.
>
> In this case the failure is simply because system_state is
> not set to SYSTEM_POWER_OFF before
> kernel/power/disk.c:power_down() calls device_shutdown().
> The appropriate reboot notifier is also not called..

Can you suggest patch to do it right? Or perhaps there should be
just_plain_power_machine_down() that does all neccessary
trickery?
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!