From: Nishanth Aravamudan <nacc@us.ibm.com>
To: len.brown@intel.com
Cc: Kernel-Janitors <kernel-janitors@lists.osdl.org>,
acpi-devel@lists.sourceforge.net
Subject: [KJ] [UPDATE PATCH] acpi/osl: correct HZ dependencies
Date: Wed, 2 Mar 2005 11:59:14 -0800 [thread overview]
Message-ID: <20050302195914.GI2741@us.ibm.com> (raw)
In-Reply-To: <20050302194821.GG2741@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]
On Wed, Mar 02, 2005 at 11:48:21AM -0800, Nishanth Aravamudan wrote:
> Hi,
>
> Please consider applying.
>
> Description: The osl driver has a few dependencies on HZ which are not
> handled correctly for all values. Use msleep_interruptible() and
> jiffies_to_msecs() to rectify the situation. Patch is compile-tested.
Sorry forgot Signed-off-by line.
Description: The osl driver has a few dependencies on HZ which are not
handled correctly for all values. Use msleep_interruptible() and
jiffies_to_msecs() to rectify the situation. Patch is compile-tested.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.11-kj-v/drivers/acpi/osl.c 2005-03-01 23:38:38.000000000 -0800
+++ 2.6.11-kj/drivers/acpi/osl.c 2005-03-02 11:47:34.000000000 -0800
@@ -317,8 +317,7 @@ acpi_os_remove_interrupt_handler(u32 irq
void
acpi_os_sleep(acpi_integer ms)
{
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(((signed long) ms * HZ) / 1000);
+ msleep_interruptible((unsigned int)ms);
}
EXPORT_SYMBOL(acpi_os_sleep);
@@ -938,7 +937,7 @@ acpi_os_wait_semaphore(
// TODO: A better timeout algorithm?
{
int i = 0;
- static const int quantum_ms = 1000/HZ;
+ unsigned int quantum_ms = jiffies_to_msecs(1);
ret = down_trylock(sem);
for (i = timeout; (i > 0 && ret < 0); i -= quantum_ms) {
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2005-03-02 19:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-02 19:48 [PATCH] acpi/osl: correct HZ dependencies Nishanth Aravamudan
2005-03-02 19:59 ` Nishanth Aravamudan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050302195914.GI2741@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=kernel-janitors@lists.osdl.org \
--cc=len.brown@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox