Re: Re: [Suspend2-devel] Cause of Suspend2 resume failures on Toshiba laptops

Pavel Machek
2005-03-05T17:56:41Z

Hi!

> > You are on the right track , it does the trick, I did serveral
> > suspend/resume cycles whitout problems.
> >
> > But (yes, it's a but :) it is functionally equivalent with using the
> > other workaround (booting at resume with acpi=off) meaning that I lose
> > all the acpi events (AC events, LID events, etc). The system records the
> > event (if I do an "watch cat /proc/acpi/ac_adapter/ADP1/state" it shows
> > the current state correctly) but acpid does not receive the event, and
> > thus can not act accordingly :( (Toshiba Satellite Pro 6100)
>
> Ahh, d'oh. Try this patch instead.
>
> After more investigation, it seems that the issue is the GPE is
> fired but not serviced because kacpid is frozen. This in itself
> would be okay, however, the GPE isn't being disabled before the
> method executes (despite there being code there to do so), and hence
> fires continuously.

Perhaps you should fix that, too? It is going to cause ugly perfrmance problems.

> The attached patch makes kacpid NOFREEZE so the GPE does get
> serviced (eventually), but probably still isn't the correct
> solution. (A better solution being making sure the GPE gets disabled
> in the first place ... still looking into this).

Looks good to me. It is good idea for other reasons, too: like we'll be
able to fight overheat during writing pages.

Pavel
> --- linux-2.6.9-rc1/drivers/acpi/osl.c.orig 2005-03-05 17:44:13.000000000 +0800
> +++ linux-2.6.9-rc1/drivers/acpi/osl.c 2005-03-05 17:44:16.000000000 +0800
> @@ -87,7 +87,7 @@
> return AE_NULL_ENTRY;
> }
> #endif
> - kacpid_wq = create_singlethread_workqueue("kacpid", 0);
> + kacpid_wq = create_singlethread_workqueue("kacpid", PF_NOFREEZE);
> BUG_ON(!kacpid_wq);
>
> return AE_OK;

--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.