From: Dmitry Torokhov <dtor_core-yWtbtysYrB+LZ21kGMrzwg@public.gmane.org>
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Rajesh Shah <rajesh.shah-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: gregkh-l3A5Bk7waGM@public.gmane.org,
tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-pci-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
pcihpd-discuss-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch 06/12] Link newly created pci child bus to its parent on creation
Date: Fri, 18 Mar 2005 23:00:12 -0500 [thread overview]
Message-ID: <200503182300.12924.dtor_core@ameritech.net> (raw)
In-Reply-To: <20050318140922.F1145-39QZ/XbsZ5/mO6KZMuUCQVaTQe2KTcn/@public.gmane.org>
Hi,
On Friday 18 March 2005 17:09, Rajesh Shah wrote:
> + if (dev->subordinate) {
> + if (list_empty(&dev->subordinate->node)) {
> + spin_lock(&pci_bus_lock);
> + list_add_tail(&dev->subordinate->node,
> + &dev->bus->children);
> + spin_unlock(&pci_bus_lock);
> + }
Should'nt spin_lock/unlock be around entire "if" statement? list_empty
could become false after it was checkled but before spinlock was acquired.
--
Dmitry
next prev parent reply other threads:[~2005-03-19 4:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050318133856.A878@unix-os.sc.intel.com>
2005-03-18 21:59 ` [Patch 2/12] Fix pci_enable_device() for p2p bridges Rajesh Shah
2005-03-18 22:02 ` [patch 03/12] Make pcibios_fixup_bus() hot-plug safe Rajesh Shah
[not found] ` <20050318133856.A878-39QZ/XbsZ5/mO6KZMuUCQVaTQe2KTcn/@public.gmane.org>
2005-03-18 22:04 ` [patch 04/12] Prevent duplicate bus numbers when scanning PCI bridge Rajesh Shah
2005-03-18 22:07 ` [patch 05/12] Take the PCI lock when modifying pci bus or device lists Rajesh Shah
2005-03-18 22:09 ` [patch 06/12] Link newly created pci child bus to its parent on creation Rajesh Shah
[not found] ` <20050318140922.F1145-39QZ/XbsZ5/mO6KZMuUCQVaTQe2KTcn/@public.gmane.org>
2005-03-19 4:00 ` Dmitry Torokhov [this message]
[not found] ` <200503182300.12924.dtor_core-yWtbtysYrB+LZ21kGMrzwg@public.gmane.org>
2005-03-19 4:01 ` Dmitry Torokhov
2005-03-18 22:11 ` [patch 07/12] Make the PCI remove routines safe for failed hot-plug Rajesh Shah
2005-03-19 5:14 ` Greg KH
2005-03-18 22:16 ` [patch 09/12] Read bridge resources when fixing up the bus Rajesh Shah
2005-03-18 22:18 ` [patch 10/12] Allow ACPI .add and .start operations to be done independently Rajesh Shah
2005-03-18 22:20 ` [patch 11/12] Export the interface to get PCI id for an ACPI handle Rajesh Shah
2005-03-18 22:22 ` [patch 12/12] ACPI based root bridge hot-add Rajesh Shah
2005-03-18 22:14 ` [patch 08/12] Remove hot-plugged devices that could not be allocated resources Rajesh Shah
2005-03-19 13:50 ` [RFC/Patch 0/12] ACPI based root bridge hot-add Paul Ionescu
[not found] ` <pan.2005.03.19.13.50.15.938352-/E1597aS9LQAvxtiuMwx3w@public.gmane.org>
2005-03-21 19:14 ` Rajesh Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503182300.12924.dtor_core@ameritech.net \
--to=dtor_core-ywtbtysyrb+lz21kgmrzwg@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=gregkh-l3A5Bk7waGM@public.gmane.org \
--cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pci-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/@public.gmane.org \
--cc=pcihpd-discuss-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=rajesh.shah-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox