2.6.12-rc2-mm1: ACPI=y, ACPI_BOOT=n problems

2.6.12-rc2-mm1: ACPI=y, ACPI_BOOT=n problems

[Adrian Bunk]

On Wed, Apr 06, 2005 at 12:32:52AM +1200, Reuben Farrelly wrote:
> Hi again
> 
> At 12:14 a.m. 6/04/2005, Adrian Bunk wrote:
> >On Tue, Apr 05, 2005 at 08:34:11PM +1200, Reuben Farrelly wrote:
> >
> >> Hi,
> >
> >Hi Reuben,
> >
> >>...
> >> Hrm. Something changed between the last -mm release which compiled
> >> through, and this one..
> >>...
> >>   LD      .tmp_vmlinux1
> >> arch/i386/kernel/built-in.o(.init.text+0x1823): In function `setup_arch':
> >> : undefined reference to `acpi_boot_table_init'
> >> arch/i386/kernel/built-in.o(.init.text+0x1828): In function `setup_arch':
> >> : undefined reference to `acpi_boot_init'
> >> make: *** [.tmp_vmlinux1] Error 1
> >> [root@tornado linux-2.6]#
> >>
> >> Backing out bk-acpi.patch works around it..
> >
> >Please send your .config .
> 
> Have just figured out that it seems to be caused by having ACPI 
> disabled in .config, once I re-enabled ACPI the build problem went away.
> 
> Config attached anyway, I imagine the problem is quite reproduceable..

Ah, this was the working .config .
fter setting CONFIG_ACPI=n I started seeing different but most likely 
related problems.


@Len:
ACPI=y and ACPI_BOOT=n seems to be a legal configuration (with 
X86_HT=y), but it breaks into pieces if you try the compilation.

The first error I get is:

<--  snip  -->

  CC      arch/i386/kernel/setup.o
arch/i386/kernel/setup.c:96: error: parse error before "acpi_sci_flags"
arch/i386/kernel/setup.c:96: warning: type defaults to `int' in 
declaration of `acpi_sci_flags'
arch/i386/kernel/setup.c:96: warning: data definition has no type or 
storage class
arch/i386/kernel/setup.c: In function `parse_cmdline_early':
arch/i386/kernel/setup.c:811: error: request for member `trigger' in 
something not a structure or union
arch/i386/kernel/setup.c:814: error: request for member `trigger' in 
something not a structure or union
arch/i386/kernel/setup.c:817: error: request for member `polarity' in 
something not a structure or union
arch/i386/kernel/setup.c:820: error: request for member `polarity' in 
something not a structure or union
arch/i386/kernel/setup.c: In function `setup_arch':
arch/i386/kernel/setup.c:1571: warning: implicit declaration of function 
`acpi_boot_table_init'
arch/i386/kernel/setup.c:1572: warning: implicit declaration of function 
`acpi_boot_init'
make[1]: *** [arch/i386/kernel/setup.o] Error 1
make: *** [arch/i386/kernel] Error 2

<--  snip  -->


> Reuben

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.6.12-rc2-mm1: ACPI=y, ACPI_BOOT=n problems

[Steven Cole]

Adrian Bunk wrote:
> On Wed, Apr 06, 2005 at 12:32:52AM +1200, Reuben Farrelly wrote:
> 
>>Hi again
>>
>>At 12:14 a.m. 6/04/2005, Adrian Bunk wrote:
>>
>>>On Tue, Apr 05, 2005 at 08:34:11PM +1200, Reuben Farrelly wrote:
>>>
>>>
>>>>Hi,
>>>
>>>Hi Reuben,
>>>
>>>
>>>>...
>>>>Hrm. Something changed between the last -mm release which compiled
>>>>through, and this one..
>>>>...
>>>>  LD      .tmp_vmlinux1
>>>>arch/i386/kernel/built-in.o(.init.text+0x1823): In function `setup_arch':
>>>>: undefined reference to `acpi_boot_table_init'
>>>>arch/i386/kernel/built-in.o(.init.text+0x1828): In function `setup_arch':
>>>>: undefined reference to `acpi_boot_init'
>>>>make: *** [.tmp_vmlinux1] Error 1
>>>>[root@tornado linux-2.6]#
>>>>
>>>>Backing out bk-acpi.patch works around it..
>>>
>>>Please send your .config .
>>
>>Have just figured out that it seems to be caused by having ACPI 
>>disabled in .config, once I re-enabled ACPI the build problem went away.
>>
>>Config attached anyway, I imagine the problem is quite reproduceable..
> 
> 
> Ah, this was the working .config .
> fter setting CONFIG_ACPI=n I started seeing different but most likely 
> related problems.
> 
> 
> @Len:
> ACPI=y and ACPI_BOOT=n seems to be a legal configuration (with 
> X86_HT=y), but it breaks into pieces if you try the compilation.
> 

Here is some additional and hopefully helpful information.
Without CONFIG_ACPI=y, I first got:

arch/i386/kernel/setup.c: In function 'setup_arch':
arch/i386/kernel/setup.c:1571: warning: implicit declaration of function 'acpi_boot_table_init'
arch/i386/kernel/setup.c:1572: warning: implicit declaration of function 'acpi_boot_init'

and then at the end:

arch/i386/kernel/built-in.o(.init.text+0x1b81): In function `setup_arch':
: undefined reference to `acpi_boot_table_init'
arch/i386/kernel/built-in.o(.init.text+0x1b86): In function `setup_arch':
: undefined reference to `acpi_boot_init'
make: *** [.tmp_vmlinux1] Error 1

With these set linux-2.6.12-rc2-mm1 built OK.

[steven@spc1 linux-2.6.12-rc2-mm1]$ grep ^CONFIG_ACPI .config
CONFIG_ACPI=y
CONFIG_ACPI_BOOT=y
CONFIG_ACPI_INTERPRETER=y
CONFIG_ACPI_BLACKLIST_YEAR=0
CONFIG_ACPI_BUS=y
CONFIG_ACPI_EC=y
CONFIG_ACPI_POWER=y
CONFIG_ACPI_PCI=y
CONFIG_ACPI_SYSTEM=y

Steven


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

Re: 2.6.12-rc2-mm1: ACPI=y, ACPI_BOOT=n problems

[Andrew Morton]

Steven Cole <elenstev-dIRlkrwy3vBBDgjK7y7TUQ@public.gmane.org> wrote:
>
> arch/i386/kernel/setup.c: In function 'setup_arch':
>  arch/i386/kernel/setup.c:1571: warning: implicit declaration of function 'acpi_boot_table_init'
>  arch/i386/kernel/setup.c:1572: warning: implicit declaration of function 'acpi_boot_init'


diff -puN include/linux/acpi.h~no-acpi-build-fix include/linux/acpi.h
--- 25/include/linux/acpi.h~no-acpi-build-fix	2005-04-05 00:14:46.000000000 -0700
+++ 25-akpm/include/linux/acpi.h	2005-04-05 00:23:39.000000000 -0700
@@ -418,16 +418,6 @@ extern int sbf_port ;
 
 #define acpi_mp_config	0
 
-static inline int acpi_boot_init(void)
-{
-	return 0;
-}
-
-static inline int acpi_boot_table_init(void)
-{
-	return 0;
-}
-
 #endif 	/*!CONFIG_ACPI_BOOT*/
 
 unsigned int acpi_register_gsi (u32 gsi, int edge_level, int active_high_low);
@@ -538,5 +528,18 @@ static inline int acpi_get_pxm(acpi_hand
 
 extern int pnpacpi_disabled;
 
+#else	/* CONFIG_ACPI */
+
+static inline int acpi_boot_init(void)
+{
+	return 0;
+}
+
+static inline int acpi_boot_table_init(void)
+{
+	return 0;
+}
+
 #endif	/* CONFIG_ACPI */
+
 #endif	/* _LINUX_ACPI_H */
_



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

Re: 2.6.12-rc2-mm1: ACPI=y, ACPI_BOOT=n problems

[Steven Cole]

Andrew Morton wrote:
> Steven Cole <elenstev@mesatop.com> wrote:
> 
>>arch/i386/kernel/setup.c: In function 'setup_arch':
>> arch/i386/kernel/setup.c:1571: warning: implicit declaration of function 'acpi_boot_table_init'
>> arch/i386/kernel/setup.c:1572: warning: implicit declaration of function 'acpi_boot_init'
> 
> 
> 
> diff -puN include/linux/acpi.h~no-acpi-build-fix include/linux/acpi.h
> --- 25/include/linux/acpi.h~no-acpi-build-fix	2005-04-05 00:14:46.000000000 -0700
> +++ 25-akpm/include/linux/acpi.h	2005-04-05 00:23:39.000000000 -0700
> @@ -418,16 +418,6 @@ extern int sbf_port ;
[patch snipped]

Yes, that worked with no CONFIG_ACPI.  Thanks.

On a slightly offtopic note, I'm now using this gcc:
gcc (GCC) 4.0.0 20050308 (Red Hat 4.0.0-0.32)

I don't have any quantitative data at hand, this seems SLOOOOW.
I guess that's progress.  But it slows down testing somewhat.

Steven

Re: 2.6.12-rc2-mm1: ACPI=y, ACPI_BOOT=n problems

[Andrew Morton]

Steven Cole <elenstev-dIRlkrwy3vBBDgjK7y7TUQ@public.gmane.org> wrote:
>
> Andrew Morton wrote:
> > Steven Cole <elenstev-dIRlkrwy3vBBDgjK7y7TUQ@public.gmane.org> wrote:
> > 
> >>arch/i386/kernel/setup.c: In function 'setup_arch':
> >> arch/i386/kernel/setup.c:1571: warning: implicit declaration of function 'acpi_boot_table_init'
> >> arch/i386/kernel/setup.c:1572: warning: implicit declaration of function 'acpi_boot_init'
> > 
> > 
> > 
> > diff -puN include/linux/acpi.h~no-acpi-build-fix include/linux/acpi.h
> > --- 25/include/linux/acpi.h~no-acpi-build-fix	2005-04-05 00:14:46.000000000 -0700
> > +++ 25-akpm/include/linux/acpi.h	2005-04-05 00:23:39.000000000 -0700
> > @@ -418,16 +418,6 @@ extern int sbf_port ;
> [patch snipped]
> 
> Yes, that worked with no CONFIG_ACPI.  Thanks.

OK, I'll keep spamming the acpi guys with it until they tell me to shut up.

> On a slightly offtopic note, I'm now using this gcc:
> gcc (GCC) 4.0.0 20050308 (Red Hat 4.0.0-0.32)
> 
> I don't have any quantitative data at hand, this seems SLOOOOW.
> I guess that's progress.  But it slows down testing somewhat.
> 

There's a reason why I persist in keeping the kernel working with
gcc-2.95.4!



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

RE: 2.6.12-rc2-mm1: ACPI=y, ACPI_BOOT=n problems

[Brown, Len]

>@Len:
>ACPI=y and ACPI_BOOT=n seems to be a legal configuration (with 
>X86_HT=y), but it breaks into pieces if you try the compilation.

yeah, don't do that:-)
I'm sorry I didn't push the patch to delete CONFIG_ACPI_BOOT earlier.
For now, just enable them both.

thanks,
-Len