From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Li Shaohua <shaohua.li@intel.com>,
ACPI-DEV <acpi-devel@lists.sourceforge.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@suse.cz>,
Zwane Mwaikambo <zwane@linuxpower.ca>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 3/6]init call cleanup
Date: Tue, 12 Apr 2005 11:32:29 +0200 [thread overview]
Message-ID: <200504121132.30027@bilbo.math.uni-mannheim.de> (raw)
In-Reply-To: <1113283855.27646.428.camel@sli10-desk.sh.intel.com>
Li Shaohua wrote:
> Trival patch for CPU hotplug. In CPU identify part, only did cleaup for
> intel CPUs. Need do for other CPUs if they support S3 SMP.
>
> @@ -405,7 +405,7 @@ void __init init_bsp_APIC(void)
> apic_write_around(APIC_LVT1, value);
> }
>
> -void __init setup_local_APIC (void)
> +void __devinit setup_local_APIC (void)
^
> {
> unsigned long oldvalue, value, ver, maxlvt;
>
Please remove this space while you are at it.
> @@ -556,7 +556,7 @@ void __init early_cpu_init(void)
> * and IDT. We reload them nevertheless, this function acts as a
> * 'CPU state barrier', nothing should get across.
> */
> -void __init cpu_init (void)
> +void __devinit cpu_init (void)
> {
> int cpu = smp_processor_id();
> struct tss_struct * t = &per_cpu(init_tss, cpu);
This one too.
Eike
next prev parent reply other threads:[~2005-04-12 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-12 5:31 [PATCH 3/6]init call cleanup Li Shaohua
2005-04-12 9:32 ` Rolf Eike Beer [this message]
2005-04-13 3:20 ` Li Shaohua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200504121132.30027@bilbo.math.uni-mannheim.de \
--to=eike-kernel@sf-tec.de \
--cc=acpi-devel@lists.sourceforge.net \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=shaohua.li@intel.com \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox