From: Adrian Bunk <bunk@stusta.de>
To: Alexey Dobriyan <adobriyan@mail.ru>,
Andrew Morton <akpm@osdl.org>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
len.brown@intel.com, acpi-devel@lists.sourceforge.net,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: [2.6 patch] ACPI: add two missing config.h #include's
Date: Sun, 17 Apr 2005 20:19:48 +0200 [thread overview]
Message-ID: <20050417181948.GB3625@stusta.de> (raw)
In-Reply-To: <20050416085923.A10826@flint.arm.linux.org.uk>
On Sat, Apr 16, 2005 at 08:59:23AM +0100, Russell King wrote:
> On Sat, Apr 16, 2005 at 04:38:52AM +0200, Adrian Bunk wrote:
> > In the Linux kernel, it's more common to put such header dependencies
> > for header files into the C files, but if the ACPI people agree a patch
> > to add the #include <linux/config.h> to acpi_bus.h is the other possble
> > correct solution for this issue.
>
> With the exception of linux/config.h.
>
> Do a 'make configcheck' and it'll tell you where linux/config.h is missing
> and where it shouldn't be.
OK, then the patch below is the correct solution.
cu
Adrian
<-- snip -->
This patch fixes the following warning by adding two missing config.h
#include's:
<-- snip -->
...
CC drivers/serial/8250_acpi.o
drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
drivers/serial/8250_acpi.c:51: warning: implicit declaration of function
`acpi_register_gsi'
...
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc2-mm3-full/include/acpi/acpi_bus.h.old 2005-04-17 19:05:23.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/acpi/acpi_bus.h 2005-04-17 19:05:37.000000000 +0200
@@ -26,6 +26,7 @@
#ifndef __ACPI_BUS_H__
#define __ACPI_BUS_H__
+#include <linux/config.h>
#include <linux/kobject.h>
#include <acpi/acpi.h>
--- linux-2.6.12-rc2-mm3-full/include/linux/acpi.h.old 2005-04-17 19:25:51.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/linux/acpi.h 2005-04-17 19:24:54.000000000 +0200
@@ -25,6 +25,8 @@
#ifndef _LINUX_ACPI_H
#define _LINUX_ACPI_H
+#include <linux/config.h>
+
#ifdef CONFIG_ACPI
#ifndef _LINUX
next prev parent reply other threads:[~2005-04-17 18:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050415151053.GM5456@stusta.de>
[not found] ` <E1DMTPC-000ASo-00.adobriyan-mail-ru@f13.mail.ru>
[not found] ` <E1DMTPC-000ASo-00.adobriyan-mail-ru-NYYus2/DmUsox3rIn2DAYQ@public.gmane.org>
2005-04-16 2:38 ` [2.6 patch] drivers/serial/8250_acpi.c: fix a warning Adrian Bunk
[not found] ` <20050416023852.GI4831@stusta.de>
[not found] ` <20050416085923.A10826@flint.arm.linux.org.uk>
2005-04-17 18:19 ` Adrian Bunk [this message]
2005-04-26 5:43 ` [2.6 patch] ACPI: add two missing config.h #include's Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050417181948.GB3625@stusta.de \
--to=bunk@stusta.de \
--cc=acpi-devel@lists.sourceforge.net \
--cc=adobriyan@mail.ru \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=herbert@gondor.apana.org.au \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox