public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh-l3A5Bk7waGM@public.gmane.org>
To: len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	ak-l3A5Bk7waGM@public.gmane.org
Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-pci-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 02/04] PCI: use the MCFG table to properly access pci devices (i386)
Date: Tue, 14 Jun 2005 22:31:20 -0700	[thread overview]
Message-ID: <20050615053120.GC23394@kroah.com> (raw)
In-Reply-To: <20050615053031.GB23394-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>

Now that we have access to the whole MCFG table, let's properly use it
for all pci device accesses (as that's what it is there for, some boxes
don't put all the busses into one entry.)

If, for some reason, the table is incorrect, we fallback to the "old
style" of mmconfig accesses, namely, we just assume the first entry in
the table is the one for us, and blindly use it.

Signed-off-by: Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>


---
 arch/i386/pci/mmconfig.c |   29 +++++++++++++++++++++++++----
 1 files changed, 25 insertions(+), 4 deletions(-)

--- gregkh-2.6.orig/arch/i386/pci/mmconfig.c	2005-06-14 21:53:11.000000000 -0700
+++ gregkh-2.6/arch/i386/pci/mmconfig.c	2005-06-14 22:07:52.000000000 -0700
@@ -22,10 +22,31 @@
 /*
  * Functions for accessing PCI configuration space with MMCONFIG accesses
  */
+static u32 get_base_addr(unsigned int seg, int bus)
+{
+	int cfg_num = -1;
+	struct acpi_table_mcfg_config *cfg;
+
+	while (1) {
+		++cfg_num;
+		if (cfg_num >= pci_mmcfg_config_num) {
+			/* something bad is going on, no cfg table is found. */
+			/* so we fall back to the old way we used to do this */
+			/* and just rely on the first entry to be correct. */
+			return pci_mmcfg_config[0].base_address;
+		}
+		cfg = &pci_mmcfg_config[cfg_num];
+		if (cfg->pci_segment_group_number != seg)
+			continue;
+		if ((cfg->start_bus_number <= bus) &&
+		    (cfg->end_bus_number >= bus))
+			return cfg->base_address;
+	}
+}
 
-static inline void pci_exp_set_dev_base(int bus, int devfn)
+static inline void pci_exp_set_dev_base(unsigned int seg, int bus, int devfn)
 {
-	u32 dev_base = pci_mmcfg_config[0].base_address | (bus << 20) | (devfn << 12);
+	u32 dev_base = get_base_addr(seg, bus) | (bus << 20) | (devfn << 12);
 	if (dev_base != mmcfg_last_accessed_device) {
 		mmcfg_last_accessed_device = dev_base;
 		set_fixmap_nocache(FIX_PCIE_MCFG, dev_base);
@@ -42,7 +63,7 @@
 
 	spin_lock_irqsave(&pci_config_lock, flags);
 
-	pci_exp_set_dev_base(bus, devfn);
+	pci_exp_set_dev_base(seg, bus, devfn);
 
 	switch (len) {
 	case 1:
@@ -71,7 +92,7 @@
 
 	spin_lock_irqsave(&pci_config_lock, flags);
 
-	pci_exp_set_dev_base(bus, devfn);
+	pci_exp_set_dev_base(seg, bus, devfn);
 
 	switch (len) {
 	case 1:


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click

  parent reply	other threads:[~2005-06-15  5:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-15  5:29 [PATCH 00/04] PCI: add proper MCFG support to let AMD boxes support MMCONFIG Greg KH
     [not found] ` <20050615052916.GA23394-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2005-06-15  5:30   ` [PATCH 01/04] PCI: add proper MCFG table parsing to ACPI core Greg KH
     [not found]     ` <20050615053031.GB23394-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2005-06-15  5:31       ` Greg KH [this message]
     [not found]         ` <20050615053120.GC23394-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2005-06-15  5:32           ` [PATCH 03/04] PCI: use the MCFG table to properly access pci devices (x86-64) Greg KH
     [not found]             ` <20050615053214.GD23394-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2005-06-15  5:33               ` [PATCH 04/04] PCI: let AMD boxes use MMCONFIG Greg KH
2005-06-16 22:34               ` [PATCH 03/04] PCI: use the MCFG table to properly access pci devices (x86-64) Rajesh Shah
     [not found]                 ` <20050616153404.B5337-39QZ/XbsZ5/mO6KZMuUCQVaTQe2KTcn/@public.gmane.org>
2005-06-16 22:42                   ` Greg KH
     [not found]                     ` <20050616224223.GA13619-l3A5Bk7waGM@public.gmane.org>
2005-06-16 23:00                       ` Andi Kleen
2005-06-16 23:49                         ` Brian Gerst
2005-06-17  1:15                         ` Rajesh Shah
2005-06-15  9:48         ` [PATCH 02/04] PCI: use the MCFG table to properly access pci devices (i386) Andi Kleen
     [not found]           ` <20050615094833.GB11898-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2005-06-15 17:31             ` Jeff Garzik
2005-06-15 17:54           ` Greg KH
     [not found]             ` <20050615175447.GA29138-l3A5Bk7waGM@public.gmane.org>
2005-06-15 18:23               ` Andi Kleen
     [not found]                 ` <20050615182346.GQ11898-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2005-06-15 18:35                   ` Greg KH
     [not found]                     ` <20050615183547.GA29587-l3A5Bk7waGM@public.gmane.org>
2005-06-15 19:03                       ` Andi Kleen
2005-06-15 20:21                         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050615053120.GC23394@kroah.com \
    --to=gregkh-l3a5bk7wagm@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=ak-l3A5Bk7waGM@public.gmane.org \
    --cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pci-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox