From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH 03/04] PCI: use the MCFG table to properly access pci devices (x86-64) Date: Fri, 17 Jun 2005 01:00:20 +0200 Message-ID: <20050616230020.GM7048@bragg.suse.de> References: <20050615052916.GA23394@kroah.com> <20050615053031.GB23394@kroah.com> <20050615053120.GC23394@kroah.com> <20050615053214.GD23394@kroah.com> <20050616153404.B5337@unix-os.sc.intel.com> <20050616224223.GA13619@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20050616224223.GA13619-l3A5Bk7waGM@public.gmane.org> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Greg KH Cc: Rajesh Shah , len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, ak-l3A5Bk7waGM@public.gmane.org, acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-pci-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-acpi@vger.kernel.org On Thu, Jun 16, 2005 at 03:42:23PM -0700, Greg KH wrote: > On Thu, Jun 16, 2005 at 03:34:06PM -0700, Rajesh Shah wrote: > > On Tue, Jun 14, 2005 at 10:32:14PM -0700, Greg KH wrote: > > > > > > + for (i = 0; i < pci_mmcfg_config_num; ++i) { > > > + pci_mmcfg_virt[i].cfg = &pci_mmcfg_config[i]; > > > + pci_mmcfg_virt[i].virt = ioremap_nocache(pci_mmcfg_config[i].base_address, MMCONFIG_APER_SIZE); > > > > This will map 256MB for each mmcfg aperture, probably better > > to restrict it based on bus number range for this aperture. > > It should be 1MB per bus number, right? It shouldn't make much difference anyways - we have plenty of vmalloc space on x86-64 The only advantage of using the exact number would be maybe to detect overruns. -Andi ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click