Re: oops with asus_acpi on P30/P35

Christian Aichinger
2005-09-22T12:52:48Z

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

On Thu, Sep 22, 2005 at 02:13:43PM +0200, Karol Kozimor wrote:
> Thus wrote Christian Aichinger:
> > The old patch was kind of a "Want to get this thing to work
> > for me" version. This one is more the "Let's get this thing finally
> > fixed in mainline" version now.
>
> Doesn't the fix for kernel bug #5067 help? The object actually returned by
> INIT depends on the DSDT, how can this be a problem is explained in the
> comments in the above fix.
> Best regards,

This is quite simmilar to my first patch actually, in that it
assumes P30 if model->type != ACPI_TYPE_STRING. This fixes the P30
oops, but this breaks ASUS W5A. My suspection (as mentioned
previously) is that on W5A INIT returns an ACPI_TYPE_BUFFER, which
happens to have the same memory layout as ACPI_TYPE_STRING.

So you really have to explicitly check for ACPI_TYPE_INTEGER, as my
patch does it.

As the #5067 patch does it, we can probably throw out the P30 case
in the (!buffer.pointer) path. However I'd prefer to do that cleanup
later. I just want that P30 oops fixed now without breaking other
stuff, and I'm pretty certain my patch accomplishes that.

Cheers,
Christian Aichinger

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]