Re: oops with asus_acpi on P30/P35

Timo Hoenig
2005-08-21T14:36:17Z

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

Hi,

On Fri, 2005-08-19 at 17:49 +0200, Hanno Böck wrote:

[...]

> This is still not fixed within 2.6.13_rc6. As 2.6.13 seems to be on the way
> and this bug is really grave/makes a piece of hardware unusable, can this be
> pushed to the kernel tree as soon as possible?

This patch does fix the Samsung P30 but this fix will also break support
for other systems (like the ASUS W5A), too. To get the W5A working
again, it needs something like the attached patch.

I assume that other models will stop working, too.

> cu,
>
> Hanno

See you,

Timo

[-- Attachment #2: asus_w5a.patch --]
[-- Type: text/x-patch, Size: 600 bytes --]

--- acpi_asus.c 2005-08-21 16:33:15.000000000 +0100
+++ acpu_asus.c 2005-08-21 16:33:41.000000000 +0100
@@ -1088,6 +1089,9 @@
* return anything. Catch this one and any similar here */
if (model->type == ACPI_TYPE_STRING) {
printk(KERN_NOTICE " %s model detected, ", model->string.pointer);
+ } else if (asus_info && /* Asus W5A needs this. Maybe others? */
+ strncmp(asus_info->oem_table_id, "0AAAA000", 8) == 0) {
+ printk(KERN_NOTICE "Found Asus ACPI without model type?\n");
} else {
if (asus_info && /* Samsung P30 */
strncmp(asus_info->oem_table_id, "ODEM", 4) == 0) {