From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Andrew Morton <akpm-LJ1TwQYPT6cQrrorzV6ljw@public.gmane.org>,
ACPI mailing list
<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: still crap in pci_choose_state
Date: Mon, 11 Jul 2005 20:27:38 +0200 [thread overview]
Message-ID: <20050711182738.GA1978@elf.ucw.cz> (raw)
Hi!
This is in drivers/pci/pci.c; and it is still wrong. You can't just
retype int into pm_message_t. Make it pm_message_t &state, and return
only success/failure in platform_pci_choose_state return value. Or add
PCI_POWER_ERROR to pci_power_t enum and use that.
Pavel
int (*platform_pci_choose_state)(struct pci_dev *dev, pm_message_t state);
pci_power_t pci_choose_state(struct pci_dev *dev, pm_message_t state)
{
int ret;
if (!pci_find_capability(dev, PCI_CAP_ID_PM))
return PCI_D0;
if (platform_pci_choose_state) {
ret = platform_pci_choose_state(dev, state);
if (ret >= 0)
state = ret;
}
switch (state) {
--
teflon -- maybe it is a trademark, but it should not be.
-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP,
AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar
next reply other threads:[~2005-07-11 18:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-11 18:27 Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-07-12 0:49 still crap in pci_choose_state Li, Shaohua
[not found] ` <16A54BF5D6E14E4D916CE26C9AD30575029F0E1A-4yWAQGcml66iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2005-07-12 7:53 ` Pavel Machek
[not found] ` <20050712075344.GB1854-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-07-12 8:28 ` Shaohua Li
[not found] ` <1121156888.18837.3.camel-ECwVeV2eNyQD0+JXs3kMbRL4W9x8LtSr@public.gmane.org>
2005-07-12 8:33 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050711182738.GA1978@elf.ucw.cz \
--to=pavel-+zi9xunit7i@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=akpm-LJ1TwQYPT6cQrrorzV6ljw@public.gmane.org \
--cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox