still crap in pci_choose_state

Pavel Machek
2005-07-11T18:27:38Z

Hi!

This is in drivers/pci/pci.c; and it is still wrong. You can't just
retype int into pm_message_t. Make it pm_message_t &state, and return
only success/failure in platform_pci_choose_state return value. Or add
PCI_POWER_ERROR to pci_power_t enum and use that.
Pavel

int (*platform_pci_choose_state)(struct pci_dev *dev, pm_message_t state);

pci_power_t pci_choose_state(struct pci_dev *dev, pm_message_t state)
{
int ret;
if (!pci_find_capability(dev, PCI_CAP_ID_PM))
return PCI_D0;

if (platform_pci_choose_state) {
ret = platform_pci_choose_state(dev, state);
if (ret >= 0)
state = ret;
}
switch (state) {