* [01/11] If ACPI doesn't find an irq listed, don't accept 0 as a valid PCI irq.
@ 2005-07-13 18:41 Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2005-07-13 18:41 UTC (permalink / raw)
To: alexn-zq6IREYz3ykAvxtiuMwx3w, len.brown-ral2JQCrhuEAvxtiuMwx3w,
acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
stable-DgEjT+Ai2ygdnm+yROfE0A, Justin Forbes, Zwane Mwaikambo,
Theodore Ts'o, Randy.Dunlap, Chuck Wolber,
torvalds-3NddpPZAyC0, akpm-3NddpPZAyC0,
alan-qBU/x9rampVanCEyBjwyrvXRex20P6io
-stable review patch. If anyone has any objections, please let us know.
------------------
If ACPI doesn't find an irq listed, don't accept 0 as a valid PCI irq.
That zero just means that nothing else found any irq information either.
Fixes http://bugme.osdl.org/show_bug.cgi?id=4824
Signed-off-by: Chris Wright <chrisw-3NddpPZAyC0@public.gmane.org>
Signed-off-by: Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>
---
drivers/acpi/pci_irq.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.12.2.orig/drivers/acpi/pci_irq.c 2005-07-13 10:53:01.000000000 -0700
+++ linux-2.6.12.2/drivers/acpi/pci_irq.c 2005-07-13 10:56:30.000000000 -0700
@@ -433,7 +433,7 @@
printk(KERN_WARNING PREFIX "PCI Interrupt %s[%c]: no GSI",
pci_name(dev), ('A' + pin));
/* Interrupt Line values above 0xF are forbidden */
- if (dev->irq >= 0 && (dev->irq <= 0xF)) {
+ if (dev->irq > 0 && (dev->irq <= 0xF)) {
printk(" - using IRQ %d\n", dev->irq);
acpi_register_gsi(dev->irq, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW);
return_VALUE(0);
-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP,
AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar
^ permalink raw reply [flat|nested] 2+ messages in thread
* [01/11] If ACPI doesn't find an irq listed, don't accept 0 as a valid PCI irq.
[not found] ` <20050713184130.GA9330-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
@ 2005-07-13 18:43 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2005-07-13 18:43 UTC (permalink / raw)
To: alexn-zq6IREYz3ykAvxtiuMwx3w, len.brown-ral2JQCrhuEAvxtiuMwx3w,
acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
stable-DgEjT+Ai2ygdnm+yROfE0A, Justin Forbes, Zwane Mwaikambo,
Theodore Ts'o, Randy.Dunlap, Chuck Wolber,
torvalds-3NddpPZAyC0, akpm-3NddpPZAyC0,
alan-qBU/x9rampVanCEyBjwyrvXRex20P6io
[resend to get threading correct, sorry]
-stable review patch. If anyone has any objections, please let us know.
------------------
If ACPI doesn't find an irq listed, don't accept 0 as a valid PCI irq.
That zero just means that nothing else found any irq information either.
Fixes http://bugme.osdl.org/show_bug.cgi?id=4824
Signed-off-by: Chris Wright <chrisw-3NddpPZAyC0@public.gmane.org>
Signed-off-by: Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>
---
drivers/acpi/pci_irq.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.12.2.orig/drivers/acpi/pci_irq.c 2005-07-13 10:53:01.000000000 -0700
+++ linux-2.6.12.2/drivers/acpi/pci_irq.c 2005-07-13 10:56:30.000000000 -0700
@@ -433,7 +433,7 @@
printk(KERN_WARNING PREFIX "PCI Interrupt %s[%c]: no GSI",
pci_name(dev), ('A' + pin));
/* Interrupt Line values above 0xF are forbidden */
- if (dev->irq >= 0 && (dev->irq <= 0xF)) {
+ if (dev->irq > 0 && (dev->irq <= 0xF)) {
printk(" - using IRQ %d\n", dev->irq);
acpi_register_gsi(dev->irq, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW);
return_VALUE(0);
-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP,
AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-07-13 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-13 18:41 [01/11] If ACPI doesn't find an irq listed, don't accept 0 as a valid PCI irq Greg KH
[not found] <20050713184130.GA9330@kroah.com>
[not found] ` <20050713184130.GA9330-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2005-07-13 18:43 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox