Re: More experiences with 2.6.13-rc3 with ec_polling patch

["Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]

On Monday, 25 of July 2005 17:26, Pavel Troller wrote:
> > Hi,
> > 
> > The problem you describe is not related to the ec_polling patch (see below).
> I know. Sorry for bad formulation of the subject, I simply wanted to tell
> "more experiences with -rc3 after fixing that one with EC :-)".
> > 
> > 
> > This happens because the sound card should drop the IRQ during
> > suspend but it doesn't.  Please try to apply the patch at
> > 
> > http://bugzilla.kernel.org/attachment.cgi?id=5371&action=view
> > 
> > and let me know if that helps.
> It seems to help just a little:
> 1) The "Nobody cared" message with the backtrace is still there the same

Is the message:

handlers:
[<dc86e850>] (snd_intel8x0_interrupt+0x0/0x240 [snd_intel8x0])

still present in the backtrace with the patch?

> 2) ohci-hcd no more complains about wrong IRQ and inserts/removes OK
> .. but nevertheless, neither soundcard now USB is working.

That would mean the patch is needed anyway ...

> Of course I verified that the patch is there in the i8x0 code.

Can you please use the attached patch instead and put printk()s right before
free_irq() in intel8x0_suspend() and request_irq() in intel8x0_resume(),
and retest?

Rafael


-- 
- Would you tell me, please, which way I ought to go from here?
- That depends a good deal on where you want to get to.
		-- Lewis Carroll "Alice's Adventures in Wonderland"

[-- Attachment #2: 2.6.13-rc3-git5-intel8x0-suspend_resume.patch --]
[-- Type: text/x-diff, Size: 923 bytes --]

--- linux-2.6.13-rc3-git5/sound/pci/intel8x0.c	2005-07-23 19:26:43.000000000 +0200
+++ patched/sound/pci/intel8x0.c	2005-07-25 18:21:36.000000000 +0200
@@ -2373,6 +2373,8 @@ static int intel8x0_suspend(snd_card_t *
 	for (i = 0; i < 3; i++)
 		if (chip->ac97[i])
 			snd_ac97_suspend(chip->ac97[i]);
+	if (chip->irq >= 0)
+		free_irq(chip->irq, (void *)chip);
 	pci_disable_device(chip->pci);
 	return 0;
 }
@@ -2384,7 +2386,14 @@ static int intel8x0_resume(snd_card_t *c
 
 	pci_enable_device(chip->pci);
 	pci_set_master(chip->pci);
-	snd_intel8x0_chip_init(chip, 0);
+	if (request_irq(chip->irq, snd_intel8x0_interrupt, SA_INTERRUPT|SA_SHIRQ, card->shortname, (void *)chip)) {
+		snd_printk("unable to grab IRQ %d\n", chip->irq);
+		chip->irq = -1;
+		pci_disable_device(chip->pci);
+		return -EBUSY;
+	}
+	synchronize_irq(chip->irq);
+	snd_intel8x0_chip_init(chip, 1);
 
 	/* refill nocache */
 	if (chip->fix_nocache)