From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [ACPI] Re: [PATCH] 2.6.13-rc3-git5: fix Bug #4416 (1/2) Date: Wed, 27 Jul 2005 22:52:49 +0200 Message-ID: <20050727205249.GA708@openzaurus.ucw.cz> References: <200507261247.05684.rjw@sisk.pl> <200507261251.48291.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Takashi Iwai Cc: "Rafael J. Wysocki" , LKML , ACPI mailing list , Andrew Morton , alsa-devel@alsa-project.org List-Id: linux-acpi@vger.kernel.org Hi! > > The following patch adds free_irq() and request_irq() to the suspend and > > resume, respectively, routines in the snd_intel8x0 driver. > > The patch looks OK to me although I have some concerns. > > - The error in resume can't be handled properly. > > What should we do for the error of request_irq()? > > - Adding this to all drivers seem too much. There's probably no other way. Talk to Len Brown. > We just need to stop the irq processing until resume, so something > like suspend_irq(irq, dev_id) and resume_irq(irq, dev_id) would be > more uesful? Its more complex than that. Irq numbers may change during resume. -- 64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf