From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH]Disable ACPI PCI link device if no PCI device uses it - takes 2 Date: Wed, 27 Jul 2005 22:25:08 -0700 Message-ID: <20050728052508.GC13585@kroah.com> References: <1122364343.7106.3.camel@linux-hp.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1122364343.7106.3.camel-ECwVeV2eNyQD0+JXs3kMbRL4W9x8LtSr@public.gmane.org> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Shaohua Li Cc: acpi-dev , Len List-Id: linux-acpi@vger.kernel.org On Tue, Jul 26, 2005 at 03:52:23PM +0800, Shaohua Li wrote: > Hi, > Looks like people agree device drivers should call > free_irq/pci_disable_irq at suspend time per the OLS report. This patch > tries to disable pci link device if no PCI device is using it, which is > one goal of pci driver calls pci_disable_irq. This patch also warns > users if some drivers don't call pci_disable_irq at suspend time. Next > step we will implement acpi_unregister_gsi for x86/x86_64, so we can > automically mask ioapic/pic if no device is using them. And in the same > way, alarm users if driver doesn't call free_irq at suspend time. > Greg, is the PCI part ok for you? It just has very small changes in PCI > part. Looks ok to me. thanks, greg k-h ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf