Re: Linux v2.6.13-rc3

Re: Linux v2.6.13-rc3

[Linus Torvalds]

Len, ACPI people - can we fix this regression, please?

Rafael even pinpoints exactly which patches are causing the problem, so 
why didn't they get reverted before sending them off to me?

Grumble. I don't like being sent known-bad patches when we're trying to 
calm things down.

		Linus


On Wed, 13 Jul 2005, Rafael J. Wysocki wrote:
>
> Hi,
> 
> On Wednesday, 13 of July 2005 07:05, Linus Torvalds wrote:
> > 
> > Yes,
> >  it's _really_ -rc3 this time, never mind the confusion with the commit 
> > message last time (when the Makefile clearly said -rc2, but my over-eager 
> > fingers had typed in a commit message saying -rc3).
> > 
> > There's a bit more changes here than I would like, but I'm putting my foot 
> > down now. Not only are a lot of people going to be gone next week for LKS 
> > and OLS, but we've gotten enough stuff for 2.6.13, and we need to calm 
> > down.
> 
> FYI, on my box (Asus L5D, Athlon 64 + nForce3, 64-bit kernel) there are two
> regressions wrt -rc2 related to ACPI.  First, the battery monitor does not work
> (http://bugzilla.kernel.org/show_bug.cgi?id=4665)
> and second, the box hangs solid during resume from disk if IO-APIC is not used
> (http://bugzilla.kernel.org/show_bug.cgi?id=4416).
> 
> The problems have been known for quite some time and remain unresolved,
> but apparently they have made it to mainline nevertheless.  I understand
> nobody else has reported them, but I also know of some people who run
> Linux on the same hardware and 2.6.13 will not work for them if these
> issues are present in it.
> 
> Greets,
> Rafael
> 
> 
> -- 
> - Would you tell me, please, which way I ought to go from here?
> - That depends a good deal on where you want to get to.
> 		-- Lewis Carroll "Alice's Adventures in Wonderland"
> 


-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP, 
AMD, and NVIDIA.  To register visit http://www.hp.com/go/dualwebinar

Re: Linux v2.6.13-rc3

[Jose Luis Domingo Lopez]

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

On Wednesday, 13 July 2005, at 11:53:08 -0700,
Linus Torvalds wrote:

> Len, ACPI people - can we fix this regression, please?
> 
> Rafael even pinpoints exactly which patches are causing the problem, so 
> why didn't they get reverted before sending them off to me?
> 
> Grumble. I don't like being sent known-bad patches when we're trying to 
> calm things down.
> 
Also related to ACPI, a patch went in recently that prevents some boxes (at
least mine) to power off properly via ACPI. The patch is:
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdif
f;h=cee5dab4856f51c5cad3aecc630ad0a4d2217a85

As the commit log says, this was somewhat expected. I sent a message a
couple of days ago both to the list and to Eric W. Biederman, with no
response so far. Message Subject: is:
[2.6.12-git8] ACPI shutdown fails to power off machine
http://marc.theaimsgroup.com/?l=linux-kernel&m=112094139204799&w=2

Greetings,

-- 
Jose Luis Domingo Lopez
Linux Registered User #189436     Debian Linux Sid (Linux 2.6.13-rc2)


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Linux v2.6.13-rc3

[Sebastian Kaergel]

On Tue, 12 Jul 2005 22:05:00 -0700 (PDT)
Linus Torvalds <torvalds-3NddpPZAyC0@public.gmane.org> wrote:

> Dmitry Torokhov:
>   [ACPI] Enable EC Burst Mode

After booting 2.6.13-rc3 on my acer travlemate 291LCI it starts
complaining:

 acpi_ec-0217 [30] acpi_ec_leave_burst_mo: ------->status fail
 acpi_ec-0217 [30] acpi_ec_leave_burst_mo: ------->status fail

2.6.13-rc{1,2} did not have this problem.


-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP, 
AMD, and NVIDIA.  To register visit http://www.hp.com/go/dualwebinar

RE: Linux v2.6.13-rc3

[Brown, Len]

>Len, ACPI people - can we fix this regression, please?
>
>Rafael even pinpoints exactly which patches are causing the 
>problem, so why didn't they get reverted before sending them off to me?

Linus,
I'm sorry it was in '-rc3' -- that is as soon as I could
muster the bk->git transition.  Now that I'm running on git,
I expect I'll be able to get the development/testing/push
pipeline moving and back on schedule.

Yes, we discovered both of these regressions in mm.
Yes, Rafael has been a sport in filing good bug reports,
and his Asus L5D has been an interesting case.

Although we broke this system, I do believe that there is
significant value in keeping these changes in the mainline,
as I believe that it is the fastest path to improved support
for all systems.  Specifically...

Re: the EC burst mode regression.
This is an extremely important fix that has been nagging
many systems for years.  It has been reported to us by
distros as well as on kernel.org:
http://bugzilla.kernel.org/show_bug.cgi?id=3851
There has been a lot of discussion about this on the
mailing list and there have been several generations
of patches.  We are confident that this approach
is the correct solution, but clearly there are
some snags.  It is probable that the snags are
model specific.

Ironically, it would be a benefit if more machines
broke like the Asus L5D because we've had a heck of
a time trying to reproduce this.  Indeed, I purchased
an AMD laptop as similar to that model as I could find
and shipped it to China explicitly for Luming to debug
this very issue.  Alas, that model, only slightly different,
works perfectly...

Re: pci_link.c regression on suspend/resume
This is the issue that Patrick was trying to describe in the KS --
that we're knowingly breaking some drivers on suspend/resume.
http://bugzilla.kernel.org/show_bug.cgi?id=3469
We intentionally removed a hack we put in to blindly restore
PCI interrupt links.  The hack can never be reliable
because the AML interpreter must run to restore PCI links
and it must run arbitrary AML code.  But it can sleep on
memory allocation and semaphores, and thus can't reliably
run before we have interrupts enabled.

We discussed this on linux-pm and at the PM-summit, and the
consensus was that making the interrupt restoring process on
resume more like boot will lead to a more robust design.
The down-side is that drivers that worked before will break,
and it is not a quick fix as we work our way through it.

thanks,
-Len


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id\x16492&op=click

Re: Linux v2.6.13-rc3

[Rafael J. Wysocki]

Hi,

On Thursday, 21 of July 2005 07:30, Brown, Len wrote:
> >Len, ACPI people - can we fix this regression, please?
> >
> >Rafael even pinpoints exactly which patches are causing the 
> >problem, so why didn't they get reverted before sending them off to me?
> 
> Linus,
> I'm sorry it was in '-rc3' -- that is as soon as I could
> muster the bk->git transition.  Now that I'm running on git,
> I expect I'll be able to get the development/testing/push
> pipeline moving and back on schedule.
> 
> Yes, we discovered both of these regressions in mm.
> Yes, Rafael has been a sport in filing good bug reports,
> and his Asus L5D has been an interesting case.
> 
> Although we broke this system, I do believe that there is
> significant value in keeping these changes in the mainline,
> as I believe that it is the fastest path to improved support
> for all systems.  Specifically...

In short: If the changes are generally needed, I can live with them
(as long as I know what patches to revert :-)).

Still it would be nice to let people know what to do if they have problems with
these changes.  Many people don't run -rc kernels and even more people
don't run -mm, so they have no idea that there are known regressions  ...

Greets,
Rafael


-- 
- Would you tell me, please, which way I ought to go from here?
- That depends a good deal on where you want to get to.
		-- Lewis Carroll "Alice's Adventures in Wonderland"


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click

RE: Linux v2.6.13-rc3

[Brown, Len]

>Still it would be nice to let people know what to do if they 
>have problems with
>these changes.  Many people don't run -rc kernels and even more people
>don't run -mm, so they have no idea that there are known 
>regressions  ...

I hope the broader exposure will break the EC patch on
another machine (besides your rare Asus) so that we
can figure it out and get it fixed for everybody.

Re: the S3 interrupt resume issue.  We're hoping to fix
the most common drivers before the release ships; and
we'd like to have a method to detect when drivers
do not release their interrupt so that we can at
least have a warning to the user to unload the
offending module until it gets fixed.

thanks for your support,
-Len

Re: Linux v2.6.13-rc3

[Andrew Morton]

Sebastian Kaergel <mailing-HmhXUwHVxSOoYr4blSSd5g@public.gmane.org> wrote:
>
> On Tue, 12 Jul 2005 22:05:00 -0700 (PDT)
> Linus Torvalds <torvalds-3NddpPZAyC0@public.gmane.org> wrote:
> 
> > Dmitry Torokhov:
> >   [ACPI] Enable EC Burst Mode
> 
> After booting 2.6.13-rc3 on my acer travlemate 291LCI it starts
> complaining:
> 
>  acpi_ec-0217 [30] acpi_ec_leave_burst_mo: ------->status fail
>  acpi_ec-0217 [30] acpi_ec_leave_burst_mo: ------->status fail
> 
> 2.6.13-rc{1,2} did not have this problem.

We reverted the ec burst mode changes.  I'll assume that 2.6.13-rc6 fixes
this up for you.  If not, or if problems remain, please let us know. 
Preferably via bugzilla.kernel.org, thanks.



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf