From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: Kenji Kaneshige
<kaneshige.kenji-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Cc: Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>,
Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH 2.6.13-rc4 1/2] fix possible null pointer access - acpi_pci_irq_enable
Date: Fri, 5 Aug 2005 09:19:18 +0200 [thread overview]
Message-ID: <20050805071918.GG1780@elf.ucw.cz> (raw)
In-Reply-To: <42F2C20F.4050807-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Hi!
> >Should people be passing NULLs here, anyway? Is not the right fix to
> >remove the check, and remove the (!dev) check, too, and just fix the
> >callers? People are going to fix the oops, but noone is going to see
> >that ACPI_DEBUG_PRINT...
>
> As you said, I think people should not pass NULLs here, and we should
> fix the caller. But I think it is not bad to check (!dev) and (!dev->bus)
> in these functions instead of panic. How about using WARN_ON here to
> notify people of badness?
No, just read l-k archives. Just dereference it. It wil oops in a nice
way, and developer *will* see and fix it.
Pavel
--
if you have sharp zaurus hardware you don't need... you know my address
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
next prev parent reply other threads:[~2005-08-05 7:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-01 3:32 [PATCH 2.6.13-rc4 0/2] fix possible null pointer access in acpi_pci_irq_{enable, disable} Kenji Kaneshige
[not found] ` <42ED97C2.7060409-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2005-08-01 3:34 ` [PATCH 2.6.13-rc4 1/2] fix possible null pointer access - acpi_pci_irq_enable Kenji Kaneshige
[not found] ` <42ED9830.7060808-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2005-08-03 11:36 ` Pavel Machek
[not found] ` <20050803113637.GB4038-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-08-05 1:34 ` Kenji Kaneshige
[not found] ` <42F2C20F.4050807-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2005-08-05 7:19 ` Pavel Machek [this message]
[not found] ` <20050805071918.GG1780-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-08-08 4:24 ` Kenji Kaneshige
[not found] ` <42F6DE69.5090101-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2005-08-08 5:07 ` Andrew Morton
2005-08-01 3:35 ` [PATCH 2.6.13-rc4 2/2] fix possible null pointer access - acpi_pci_irq_disable Kenji Kaneshige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050805071918.GG1780@elf.ucw.cz \
--to=pavel-+zi9xunit7i@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=akpm-3NddpPZAyC0@public.gmane.org \
--cc=kaneshige.kenji-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox