public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak-l3A5Bk7waGM@public.gmane.org>
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: [PATCH] Disable slow duplicate object tracking in ACPI_DEBUG
Date: Wed, 10 Aug 2005 13:32:55 +0200	[thread overview]
Message-ID: <20050810113255.GK19772@wotan.suse.de> (raw)


The current SUSE 10.0 beta has CONFIG_ACPI_DEBUG enabled. That lead
to severe slowdowns on several machines. One issue was the different
default for ec_burst_mode. Another one was that the object tracking
would always walk the full list of all objects, which lead to kacpid
needing up to 25% of the total CPU time.

This patch disables the slow list walking. It could be probably
replaced with a hash or similar too, but I don't think the duplicate
object tracking is too useful anaywys so I just disabled it.

-Andi

From: ak-l3A5Bk7waGM@public.gmane.org
Subject: Disable linear search in ACPI debugging
Suse-bugzilla: 102565

Looking through all the memory objects all the time is just too slow.
Don't do it.


Signed-off-by: Andi Kleen <ak-l3A5Bk7waGM@public.gmane.org>

Index: linux-2.6.13rc5/drivers/acpi/utilities/utalloc.c
===================================================================
--- linux-2.6.13rc5.orig/drivers/acpi/utilities/utalloc.c
+++ linux-2.6.13rc5/drivers/acpi/utilities/utalloc.c
@@ -674,6 +674,9 @@ acpi_ut_find_allocation (
 {
 	struct acpi_debug_mem_block     *element;
 
+	/* too slow to be usable */
+	return NULL;
+
 
 	ACPI_FUNCTION_ENTRY ();
 


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

             reply	other threads:[~2005-08-10 11:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-10 11:32 Andi Kleen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-08-11  2:14 [PATCH] Disable slow duplicate object tracking in ACPI_DEBUG Brown, Len
     [not found] ` <F7DC2337C7631D4386A2DF6E8FB22B30044D213E-N2PTB0HCzHKkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2005-08-11  2:29   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050810113255.GK19772@wotan.suse.de \
    --to=ak-l3a5bk7wagm@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox