[PATCH] IASL disassembler bug with "Missing EndDependentFunctions" comment

[PATCH] IASL disassembler bug with "Missing EndDependentFunctions" comment

[Couriousous]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

Hello 

Sorry if it's the wrong list/email, but I didn't found a better one. There is 
no email on Intel website about the iasl disassembler.

When a dependent resource list doesn't end with EndDependentFn() macro, the 
iasl disassembler print the following comment in the disassembled source:

//*** Missing EndDependentFunctions descriptor

But it forget to terminate the comment by \n. So, the "next line" is on the 
same line as the comment.

Regards,
Couriousous 

[-- Attachment #2: EndDependentFunctions-comment-fix.patch --]
[-- Type: text/x-diff, Size: 499 bytes --]

--- disassembler/dmresrc.c.origi	2005-09-02 23:16:41.000000000 +0200
+++ disassembler/dmresrc.c	2005-09-02 23:17:12.000000000 +0200
@@ -303,7 +303,7 @@
                 AcpiOsPrintf ("}\n");
                 AcpiDmIndent (Level);
 
-                AcpiOsPrintf ("//*** Missing EndDependentFunctions descriptor");
+                AcpiOsPrintf ("//*** Missing EndDependentFunctions descriptor\n");
 
                 /*
                  * We could fix the problem, but then the ASL would not match

RE: [PATCH] IASL disassembler bug with "Missing EndDependentFunctions" comment

[Moore, Robert]

This was fixed recently in the 20050729 version of the compiler

> -----Original Message-----
> From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
> admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Couriousous
> Sent: Friday, September 02, 2005 3:10 PM
> To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> Subject: [ACPI] [PATCH] IASL disassembler bug with "Missing
> EndDependentFunctions" comment
> 
> Hello
> 
> Sorry if it's the wrong list/email, but I didn't found a better one.
There
> is
> no email on Intel website about the iasl disassembler.
> 
> When a dependent resource list doesn't end with EndDependentFn()
macro,
> the
> iasl disassembler print the following comment in the disassembled
source:
> 
> //*** Missing EndDependentFunctions descriptor
> 
> But it forget to terminate the comment by \n. So, the "next line" is
on
> the
> same line as the comment.
> 
> Regards,
> Couriousous


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

Re: [PATCH] IASL disassembler bug with "Missing EndDependentFunctions" comment

[Couriousous]

Le Samedi 03 Septembre 2005 00.20, Moore, Robert a écrit :
> This was fixed recently in the 20050729 version of the compiler
>

Well, updating http://www.intel.com/technology/iapc/acpi/downloads.htm tarball 
should avoid such duplicate patch :) 

Regards,
Couriousous


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

RE: [PATCH] IASL disassembler bug with "Missing EndDependentFunctions" comment

[Moore, Robert]

True, we don't post every single release up to the web.  I am hoping to post the 09/02 release.


> -----Original Message-----
> From: Couriousous [mailto:couriousous-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org]
> Sent: Friday, September 02, 2005 3:47 PM
> To: Moore, Robert
> Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> Subject: Re: [ACPI] [PATCH] IASL disassembler bug with "Missing
> EndDependentFunctions" comment
> 
> Le Samedi 03 Septembre 2005 00.20, Moore, Robert a écrit :
> > This was fixed recently in the 20050729 version of the compiler
> >
> 
> Well, updating http://www.intel.com/technology/iapc/acpi/downloads.htm
> tarball
> should avoid such duplicate patch :)
> 
> Regards,
> Couriousous


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf