Fan resume handling - ACPI resume callbacks?

Fan resume handling - ACPI resume callbacks?

[Matthew Garrett]

I'm trying to implement resume support for the fan driver. From what I
can tell through experimentation, the easiest solution is to check if
the fan claims to be switched on, and if so to switch it off and on
again. However, my resume callback never seems to be called. I've got

static struct acpi_driver acpi_fan_driver = {
        .name =         ACPI_FAN_DRIVER_NAME,
        .class =        ACPI_FAN_CLASS,
        .ids =          ACPI_FAN_HID,
        .ops =          {
                                .add =          acpi_fan_add,
                                .remove =       acpi_fan_remove,
                                .resume =       acpi_fan_resume,
                        },
};

but adding printks to acpi_fan_resume doesn't seem to result in anything 
in the kernel logs. Is this stuff supposed to work?

-- 
Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org


-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. 
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php

RE: Fan resume handling - ACPI resume callbacks?

[Li, Shaohua]

Hi,
>
>I'm trying to implement resume support for the fan driver. From what I
>can tell through experimentation, the easiest solution is to check if
>the fan claims to be switched on, and if so to switch it off and on
>again. However, my resume callback never seems to be called. I've got
>
>static struct acpi_driver acpi_fan_driver = {
>        .name =         ACPI_FAN_DRIVER_NAME,
>        .class =        ACPI_FAN_CLASS,
>        .ids =          ACPI_FAN_HID,
>        .ops =          {
>                                .add =          acpi_fan_add,
>                                .remove =       acpi_fan_remove,
>                                .resume =       acpi_fan_resume,
>                        },
>};
>
>but adding printks to acpi_fan_resume doesn't seem to result in
anything
>in the kernel logs. Is this stuff supposed to work?
The ACPI driver model isn't plugged into Linux driver tree, so the
.resume method will never get called. I recently sent out some patches
into the list
(http://sourceforge.net/mailarchive/forum.php?thread_id=8172458&forum_id
=6102). With the patches, the .resume will work. But Dominik thought we
should not introduce acpi bus, instead we should make most ACPI devices
as platform devices. I'm still evaluating it.

Thanks,
Shaohua


-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server.
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php