From: Pavel Machek <pavel@ucw.cz>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
len.brown@intel.com, Pierre Ossman <drzeus-list@drzeus.cx>,
acpi-devel@lists.sourceforge.net, ncunningham@cyclades.com,
Masoud Sharbiani <masouds@masoud.ir>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] suspend: Cleanup calling of power off methods.
Date: Tue, 20 Sep 2005 23:06:17 +0200 [thread overview]
Message-ID: <20050920210617.GA1779@elf.ucw.cz> (raw)
In-Reply-To: <m1zmq7fx3v.fsf_-_@ebiederm.dsl.xmission.com>
Hi!
> In the lead up to 2.6.13 I fixed a large number of reboot
> problems by making the calling conventions consistent. Despite
> checking and double checking my work it appears I missed an
> obvious one.
>
> The S4 suspend code for PM_DISK_PLATFORM was also calling
> device_shutdown without setting system_state, and was
> not calling the appropriate reboot_notifier.
ACK on both. But should not you submit patch via -mm, so it gets at
least some testing there?
Pavel
--
if you have sharp zaurus hardware you don't need... you know my address
next prev parent reply other threads:[~2005-09-20 21:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F7DC2337C7631D4386A2DF6E8FB22B30047B8DAF@hdsmsx401.amr.corp.intel.com>
2005-09-10 21:07 ` reboot vs poweroff Eric W. Biederman
[not found] ` <m1d5ngk4xa.fsf-T1Yj925okcoyDheHMi7gv2pdwda3JcWeAL8bYrjMMd8@public.gmane.org>
2005-09-11 8:43 ` Meelis Roos
[not found] ` <Pine.SOC.4.61.0509111140550.9218-ptEonEWSGqKptlylMvRsHA@public.gmane.org>
2005-09-11 8:53 ` Eric W. Biederman
2005-09-20 17:42 ` [PATCH 1/2] reboot: Comment and factor the main reboot functions Eric W. Biederman
[not found] ` <m14q8fhc02.fsf_-_-T1Yj925okcoyDheHMi7gv2pdwda3JcWeAL8bYrjMMd8@public.gmane.org>
2005-09-20 17:49 ` [PATCH 2/2] suspend: Cleanup calling of power off methods Eric W. Biederman
2005-09-20 21:06 ` Pavel Machek [this message]
[not found] ` <20050920210617.GA1779-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-09-21 2:08 ` Eric W. Biederman
2005-09-21 10:18 ` Pavel Machek
2005-09-21 13:50 ` Eric W. Biederman
[not found] ` <20050921101855.GD25297-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/@public.gmane.org>
2005-09-21 16:35 ` Linus Torvalds
2005-09-21 17:28 ` Eric W. Biederman
[not found] ` <m1slvycotk.fsf-T1Yj925okcoyDheHMi7gv2pdwda3JcWeAL8bYrjMMd8@public.gmane.org>
2005-09-21 18:02 ` Andrew Morton
2005-09-21 17:36 ` Alexander Nyberg
2005-09-21 18:15 ` Andrew Morton
[not found] ` <20050921111523.4b007281.akpm-3NddpPZAyC0@public.gmane.org>
2005-09-21 19:45 ` Hugh Dickins
2005-09-21 18:35 ` Diego Calleja
[not found] ` <20050921203505.32cc714d.diegocg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2005-09-21 18:49 ` Andrew Morton
2005-09-21 19:54 ` Martin J. Bligh
2005-09-26 12:09 ` Diego Calleja
[not found] ` <20050926140900.d070b604.diegocg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2005-09-26 13:47 ` Martin J. Bligh
2005-09-21 20:16 ` Diego Calleja
2005-09-21 19:43 ` Russell King
[not found] ` <20050921194306.GC13246-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2005-09-21 20:10 ` Andrew Morton
2005-09-22 7:15 ` Pierre Ossman
2005-09-22 8:10 ` [ACPI] " Rafael J. Wysocki
[not found] ` <43325A02.90208-p3sGCRWkH8CeZLLa646FqQ@public.gmane.org>
2005-09-22 9:30 ` Eric W. Biederman
[not found] ` <m14q8dcuvm.fsf-T1Yj925okcoyDheHMi7gv2pdwda3JcWeAL8bYrjMMd8@public.gmane.org>
2005-09-22 9:38 ` Russell King
2005-09-22 10:54 ` Pierre Ossman
[not found] ` <Pine.LNX.4.58.0509210930410.2553-hNm40g4Ew95AfugRpC6u6w@public.gmane.org>
2005-09-21 17:46 ` Andrew Morton
[not found] ` <20050921104615.2e8dd7d5.akpm-3NddpPZAyC0@public.gmane.org>
2005-09-21 18:08 ` Eric W. Biederman
2005-09-21 18:24 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050920210617.GA1779@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=acpi-devel@lists.sourceforge.net \
--cc=drzeus-list@drzeus.cx \
--cc=ebiederm@xmission.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masouds@masoud.ir \
--cc=ncunningham@cyclades.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox