public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>
To: "Li, Shaohua" <shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: jonas-fAbYwIrWRvUAvxtiuMwx3w@public.gmane.org,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: Fw: ACPI, pm timer and ASUS a8v
Date: Wed, 21 Sep 2005 01:30:19 -0700	[thread overview]
Message-ID: <20050921013019.74b5059e.akpm@osdl.org> (raw)
In-Reply-To: <59D45D057E9702469E5775CBB56411F1784EB5@pdsmsx406>

"Li, Shaohua" <shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>
> >> How about add something like this:
> >> if (fadt->revision >= FADT2_REVISION_ID) {
> >> 		/* FADT rev. 2 */
> >> 		if (fadt->xpm_tmr_blk.address_space_id !=
> >> ACPI_ADR_SPACE_SYSTEM_IO)
> >> 			return 0;
> >>
> >> 		pmtmr_ioport = fadt->xpm_tmr_blk.address;
> >> +		if (!pmtmr_ioport)
> >> +			pmtmr_ioport = fadt->V1_pm_tmr_blk;
> >> 	} else {
> >> 		/* FADT rev. 1 */
> >> 		pmtmr_ioport = fadt->V1_pm_tmr_blk;
> >> 	}
> >
> >this works
> Great.
> 
> >
> >ps.
> >	I opened as andrew suggested a bug report:
> >http://bugzilla.kernel.org/show_bug.cgi?id=5283
> >ds.
> Ok, I'll attach a formal patch into bugzilla.

Please email a copy?  I fear that patches which go into bugzilla never come
out again ;)

At least, not sufficiently promptly.  We need to get fixups like this into
mainline quickly.



-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. 
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php

  reply	other threads:[~2005-09-21  8:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-21  8:23 Fw: ACPI, pm timer and ASUS a8v Li, Shaohua
2005-09-21  8:30 ` Andrew Morton [this message]
     [not found]   ` <20050921013019.74b5059e.akpm-3NddpPZAyC0@public.gmane.org>
2005-09-21  8:44     ` Shaohua Li
  -- strict thread matches above, loose matches on Subject: below --
2005-09-21  8:09 Li, Shaohua
2005-09-21 10:19 ` Jonas Oreland
2005-09-21  7:03 Li, Shaohua
2005-09-21  7:44 ` Jonas Oreland
2005-09-21  6:17 Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050921013019.74b5059e.akpm@osdl.org \
    --to=akpm-3nddppzayc0@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=jonas-fAbYwIrWRvUAvxtiuMwx3w@public.gmane.org \
    --cc=shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox