From: Rajesh Shah <rajesh.shah@intel.com>
To: Kristen Accardi <kristen.c.accardi@intel.com>
Cc: pcihpd-discuss@lists.sourceforge.net,
acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
rajesh.shah@intel.com, greg@kroah.com, len.brown@intel.com
Subject: Re: [patch 1/3] pci: store PCI_INTERRUPT_PIN in pci_dev
Date: Thu, 27 Oct 2005 16:06:59 -0700 [thread overview]
Message-ID: <20051027160658.A9674@unix-os.sc.intel.com> (raw)
In-Reply-To: <1130441409.5996.24.camel@whizzy>; from kristen.c.accardi@intel.com on Thu, Oct 27, 2005 at 12:30:09PM -0700
On Thu, Oct 27, 2005 at 12:30:09PM -0700, Kristen Accardi wrote:
> --- linux-2.6.13.orig/drivers/pci/probe.c
> +++ linux-2.6.13/drivers/pci/probe.c
> @@ -571,6 +571,7 @@ static void pci_read_irq(struct pci_dev
> unsigned char irq;
>
> pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &irq);
> + dev->pin = irq;
pci_read_irq() is not called for PCI bridges, but some of them
may need an interrupt (e.g. for shpchp, pciehp). Did you check
if this patchset broke such bridges? You should call this
function for PCI bridges too.
Rajesh
next prev parent reply other threads:[~2005-10-27 23:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20051027192603.488616000@whizzy>
2005-10-27 19:30 ` [patch 1/3] pci: store PCI_INTERRUPT_PIN in pci_dev Kristen Accardi
2005-10-27 23:06 ` Rajesh Shah [this message]
2005-11-03 0:14 ` Kristen Accardi
2005-10-27 19:30 ` [patch 2/3] apci: use stored value of pin from pci_dev Kristen Accardi
2005-10-27 19:30 ` [patch 3/3] pci: " Kristen Accardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051027160658.A9674@unix-os.sc.intel.com \
--to=rajesh.shah@intel.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=greg@kroah.com \
--cc=kristen.c.accardi@intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pcihpd-discuss@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox