public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Yu, Luming" <luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: Nishanth Aravamudan
	<nacc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
	len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [UPDATE PATCH] acpi/video: check brightness is non-NULL before writing
Date: Thu, 17 Nov 2005 14:30:16 +0800	[thread overview]
Message-ID: <200511171430.16431.luming.yu@intel.com> (raw)
In-Reply-To: <20051116204339.GK3122-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

On Thursday 17 November 2005 04:43, Nishanth Aravamudan wrote:
>
> Signed-off-by: Nishanth Aravamudan <nacc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
>
> ---
>
>  drivers/acpi/video.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -urpN 2.6.15-rc1/drivers/acpi/video.c
> 2.6.15-rc1-dev/drivers/acpi/video.c ---
> 2.6.15-rc1/drivers/acpi/video.c	2005-11-11 20:32:50.000000000 -0800 +++
> 2.6.15-rc1-dev/drivers/acpi/video.c	2005-11-16 12:40:42.000000000 -0800 @@
> -812,7 +812,7 @@ acpi_video_device_write_brightness(struc
>
>  	ACPI_FUNCTION_TRACE("acpi_video_device_write_brightness");
>
> -	if (!dev || count + 1 > sizeof str)
> +	if (!dev || !dev->brightness || count + 1 > sizeof str)
>  		return_VALUE(-EINVAL);
>
>  	if (copy_from_user(str, buffer, count))

Is it this http://bugzilla.kernel.org/show_bug.cgi?id=5571?


-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.  Get Certified Today
Register for a JBoss Training Course.  Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click

  parent reply	other threads:[~2005-11-17  6:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-12 18:44 [PATCH] acpi/video: check brightness is non-NULL before writing Nishanth Aravamudan
     [not found] ` <20050912184401.GC25471-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2005-11-16 20:43   ` [UPDATE PATCH] " Nishanth Aravamudan
     [not found]     ` <20051116204339.GK3122-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2005-11-17  6:30       ` Yu, Luming [this message]
     [not found]         ` <200511171430.16431.luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2005-11-17 16:58           ` Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200511171430.16431.luming.yu@intel.com \
    --to=luming.yu-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=nacc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox