public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak-l3A5Bk7waGM@public.gmane.org>
To: torvalds-3NddpPZAyC0@public.gmane.org,
	akpm-3NddpPZAyC0@public.gmane.org,
	len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	trenn-l3A5Bk7waGM@public.gmane.org,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: ACPI boot fix for 2.6.15
Date: Tue, 13 Dec 2005 06:28:34 +0100	[thread overview]
Message-ID: <20051213052834.GI23384@wotan.suse.de> (raw)


Hallo,

I have the following patch in my x86-64 tree because it was needed
to boot without acpi=off on several of the machines here. 
Without it the ACPI device setup code would always create a loop
in the ACPI device tree and eventually some other code walking
it would hang the machine.

The patch has been around for a long time - it was originally 
done by Thomas Renninger - and has even been shipped in SUSE 10.0
so it was well tested
(which was 2.6.13 based, there the problem only hit occasionally,
in 2.6.14+ it seems to happen more frequently for some reason)

I think it was queued in the ACPI trees too and acked by the
ACPI poeople.

I know Len skipped the ACPI update for .15 for some reason,
but could we perhaps merge this safe patch. It would help
my test machines at least :)

----

From: trenn-l3A5Bk7waGM@public.gmane.org

Avoid endless loops in ACPI device tree.

Cc: Len.Brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org

Signed-off-by: Andi Kleen <ak-l3A5Bk7waGM@public.gmane.org>

Index: linux/drivers/acpi/scan.c
===================================================================
--- linux.orig/drivers/acpi/scan.c
+++ linux/drivers/acpi/scan.c
@@ -1110,7 +1110,7 @@ acpi_add_single_object(struct acpi_devic
 	 *
 	 * TBD: Assumes LDM provides driver hot-plug capability.
 	 */
-	result = acpi_bus_find_driver(device);
+	acpi_bus_find_driver(device);
 
       end:
 	if (!result)



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click

             reply	other threads:[~2005-12-13  5:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-13  5:28 Andi Kleen [this message]
     [not found] ` <20051213052834.GI23384-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2005-12-13  5:43   ` ACPI boot fix for 2.6.15 Dave Jones
  -- strict thread matches above, loose matches on Subject: below --
2005-12-13  5:35 Brown, Len
     [not found] ` <F7DC2337C7631D4386A2DF6E8FB22B30056339F3-N2PTB0HCzHKkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2005-12-13  5:58   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051213052834.GI23384@wotan.suse.de \
    --to=ak-l3a5bk7wagm@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=akpm-3NddpPZAyC0@public.gmane.org \
    --cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=torvalds-3NddpPZAyC0@public.gmane.org \
    --cc=trenn-l3A5Bk7waGM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox