Re: [PATCH 1/2] make acpi_path_name() global (v2)

Kristen Accardi
2005-12-19T20:43:31Z

On Mon, 2005-12-19 at 11:54 -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy_d_dunlap-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>
> Make acpi_path_name() usable by everyone.
> I need this for adding SATA suspend/resume ACPI support.
>
> Signed-off-by: Randy Dunlap <randy_d_dunlap-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---
> drivers/acpi/osl.c | 21 +++++++++++++++++++++
> include/acpi/acpiosxf.h | 2 ++
> 2 files changed, 23 insertions(+)
>
> --- linux-2615-rc6-acpi.orig/drivers/acpi/osl.c
> +++ linux-2615-rc6-acpi/drivers/acpi/osl.c
> @@ -1078,6 +1078,27 @@ void acpi_os_release_lock(acpi_handle ha
> spin_unlock_irqrestore((spinlock_t *) handle, flags);
> }
>
> +/**
> + * acpi_path_name - get ACPI path_name for the given handle
> + * @handle: ACPI object handle to look up name of
> + * @namebuf: acpi_buffer with input flags and output name
> + *
> + * Caller can allocate & free the output name buffer or can set
> + * namebuf.length to ACPI_ALLOCATE_BUFFER to have ACPI-CA allocate
> + * the buffer but caller is still responsible for freeing it.
> + *
> + * Returns: status of acpi_get_name()
> + */
> +acpi_status acpi_path_name(acpi_handle handle, struct acpi_buffer *namebuf)
> +{
> + acpi_status status;
> +
> + status = acpi_get_name(handle, ACPI_FULL_PATHNAME, namebuf);
> +
> + return_ACPI_STATUS(status);
> +}
> +EXPORT_SYMBOL(acpi_path_name);
> +

Shouldn't this be EXPORT_SYMBOL_GPL instead?

Kristen