From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH 1/2] make acpi_path_name() global (v3) Date: Wed, 21 Dec 2005 05:44:54 -0700 Message-ID: <20051221124454.GA2361@parisc-linux.org> References: <20051220191828.65d0087f.rdunlap@xenotime.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20051220191828.65d0087f.rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: "Randy.Dunlap" Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, pcihpd-discuss-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kristen.c.accardi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, gregkh-l3A5Bk7waGM@public.gmane.org, robert.moore-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: linux-acpi@vger.kernel.org On Tue, Dec 20, 2005 at 07:18:28PM -0800, Randy.Dunlap wrote: > +acpi_status acpi_path_name(acpi_handle handle, struct acpi_buffer *namebuf) > +{ > + acpi_status status; > + > + status = acpi_get_name(handle, ACPI_FULL_PATHNAME, namebuf); > + > + return_ACPI_STATUS(status); > +} > +EXPORT_SYMBOL_GPL(acpi_path_name); Nope. You either need to add an "ACPI_FUNCTION_TRACE" call at the top of your function, or just do "return status;". Otherwise you'll screw up the ACPI debug code. ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click