From: Pavel Machek <pavel@ucw.cz>
To: Kristen Accardi <kristen.c.accardi@intel.com>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com,
pcihpd-discuss@lists.sourceforge.net, len.brown@intel.com,
linux-acpi@vger.kernel.org
Subject: Re: [Pcihpd-discuss] Re: [patch 0/4] Hot Dock/Undock support
Date: Wed, 18 Jan 2006 21:42:52 +0100 [thread overview]
Message-ID: <20060118204251.GA1544@elf.ucw.cz> (raw)
In-Reply-To: <1137609747.31839.6.camel@whizzy>
Hi!
There's a bug in error handling:
int __init acpiphp_glue_init(void)
{
int num = 0;
acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
ACPI_UINT32_MAX, find_root_bridges, &num,
NULL);
if (num <= 0)
return -1;
else
acpi_pci_register_driver(&acpi_pci_hp_driver);
return 0;
}
You register driver here, but if acpiphp_get_num_slots() returns 0
later, you return -ENODEV, aborting load of driver, but without
undergistering that driver. It oopses after a while. Same problem if
init_slots() returns error.
Pavel
--
Thanks, Sharp!
next prev parent reply other threads:[~2006-01-18 20:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-18 0:56 [patch 0/4] Hot Dock/Undock support Kristen Accardi
2006-01-18 12:16 ` Pavel Machek
2006-01-18 13:04 ` Pavel Machek
2006-01-18 18:42 ` [Pcihpd-discuss] " Kristen Accardi
2006-01-18 19:45 ` Pavel Machek
2006-01-18 21:06 ` Kristen Accardi
2006-01-18 21:47 ` Matthew Garrett
2006-01-18 22:08 ` Pavel Machek
2006-01-18 22:23 ` Pavel Machek
2006-01-19 0:06 ` Kristen Accardi
2006-01-19 15:23 ` Dmitry Torokhov
2006-01-18 14:51 ` Pavel Machek
2006-01-20 1:27 ` Kristen Accardi
2006-01-18 20:42 ` Pavel Machek [this message]
2006-01-18 21:43 ` Kristen Accardi
2006-01-18 21:11 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060118204251.GA1544@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=greg@kroah.com \
--cc=kristen.c.accardi@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pcihpd-discuss@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox