From: Rolf Eike Beer <eike-hotplug@sf-tec.de>
To: pcihpd-discuss@lists.sourceforge.net
Cc: MUNEDA Takahiro <muneda.takahiro@jp.fujitsu.com>,
greg@kroah.com, pavel@ucw.cz, kristen.c.accardi@intel.com,
linux-acpi@vger.kernel.org, len.brown@intel.com
Subject: Re: [Pcihpd-discuss] [PATCH 2/7] acpiphp - remove init_slots()
Date: Fri, 20 Jan 2006 11:25:59 +0100 [thread overview]
Message-ID: <200601201126.06541@bilbo.math.uni-mannheim.de> (raw)
In-Reply-To: <877j8vp5y4.wl%muneda.takahiro@jp.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
MUNEDA Takahiro wrote:
>+ slot = kmalloc(sizeof(struct slot), GFP_KERNEL);
>+ if (!slot)
>+ goto error;
>+ memset(slot, 0, sizeof(struct slot));
Use kzalloc() instead of kmalloc() and memset(). Use sizeof(*slot).
Eike
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-01-20 10:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-20 10:08 [PATCH 2/7] acpiphp - remove init_slots() MUNEDA Takahiro
2006-01-20 10:25 ` Rolf Eike Beer [this message]
2006-01-20 11:25 ` [Pcihpd-discuss] " MUNEDA Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601201126.06541@bilbo.math.uni-mannheim.de \
--to=eike-hotplug@sf-tec.de \
--cc=greg@kroah.com \
--cc=kristen.c.accardi@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=muneda.takahiro@jp.fujitsu.com \
--cc=pavel@ucw.cz \
--cc=pcihpd-discuss@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox