From: Paul Jackson <pj@sgi.com>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-ia64@vger.kernel.org, akpm@osdl.org, tony.luck@intel.com,
ak@suse.de, len.brown@intel.com, discuss@x86-64.org
Subject: Re: [RFT/PATCH]Unify mapping from pxm to node id (take 2).
Date: Thu, 26 Jan 2006 07:48:46 -0800 [thread overview]
Message-ID: <20060126074846.1a6dd300.pj@sgi.com> (raw)
In-Reply-To: <20060123165644.C147.Y-GOTO@jp.fujitsu.com>
This patch doesn't work for arch/ia64/sn (probably not for ia64/hp either).
The final link fails:
---------------------
arch/ia64/sn/built-in.o(.init.text+0x1c90): In function `sn_setup':
arch/ia64/sn/kernel/setup.c:151: undefined reference to `nid_to_pxm_map'
arch/ia64/sn/built-in.o(.init.text+0x1c91):arch/ia64/sn/kernel/setup.c:155: undefined reference to `pxm_to_nid_map'
arch/ia64/sn/built-in.o(.init.text+0x1ca0):arch/ia64/sn/kernel/setup.c:151: undefined reference to `nid_to_pxm_map'
arch/ia64/sn/built-in.o(.init.text+0x1cb0):arch/ia64/sn/kernel/setup.c:155: undefined reference to `pxm_to_nid_map'
It looks like you removed the definitions of pxm_to_nid_map and nid_to_pxm_map,
but did not remove all the uses. I recommend when removing global kernel
symbols that one grep all the kernel files for other uses.
A grep of the kernel (in Andrew's 2.6.16-rc1-mm3 quilt stack, just
after this patch and its first fix are applied) shows:
$ grep -rEIw pxm_to_nid_map\|nid_to_pxm_map * | grep -vE patches\|System.map
arch/i386/kernel/srat.c: u8 nid_to_pxm_map[MAX_NUMNODES];/* logical node ID to _PXM map */
arch/ia64/hp/common/sba_iommu.c: node = pxm_to_nid_map[pxm];
arch/ia64/sn/kernel/setup.c: nid = pxm_to_nid_map[pxm];
arch/ia64/sn/kernel/setup.c: nasid = pxm_to_nasid(nid_to_pxm_map[node]);
include/asm-ia64/acpi.h:extern int __devinitdata pxm_to_nid_map[MAX_PXM_DOMAINS];
include/asm-ia64/acpi.h:extern int __initdata nid_to_pxm_map[MAX_NUMNODES];
>From the above, I presume that arch/ia64/hp is broken, along with
arch/ia64/sn. And it looks like the nid_to_pxm_map[] in srat.c
is a waste of stack space, and the two remaining externs in
asm-ia64/acpi.h should be removed.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next prev parent reply other threads:[~2006-01-26 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-20 11:24 [RFT/PATCH]Unify mapping from pxm to node id (take 2) Yasunori Goto
2006-01-23 7:57 ` Yasunori Goto
2006-01-26 15:48 ` Paul Jackson [this message]
2006-01-28 3:34 ` [PATCH 001/003]Fix unify mapping from pxm to node id Yasunori Goto
2006-01-28 7:15 ` Paul Jackson
2006-01-29 3:44 ` Bob Picco
2006-01-29 5:04 ` Paul Jackson
2006-01-29 10:38 ` Paul Jackson
2006-01-28 3:34 ` [PATCH 002/003]Fix " Yasunori Goto
2006-01-28 3:34 ` [PATCH 003/003]Fix " Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060126074846.1a6dd300.pj@sgi.com \
--to=pj@sgi.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox